Skip to content

Fix editor losing focus on model change #1458#1472

Open
bostondevin wants to merge 2 commits intotextAngular:masterfrom
bostondevin:patch-1
Open

Fix editor losing focus on model change #1458#1472
bostondevin wants to merge 2 commits intotextAngular:masterfrom
bostondevin:patch-1

Conversation

@bostondevin
Copy link
Copy Markdown

Fix this bug: #1458

@Eblax
Copy link
Copy Markdown

Eblax commented Mar 14, 2017

I would suggest changing .+? to .*? (matching 0 or more characters instead of 1 or more characters) so that the regexp will still work as originally intended.

@MarkOdey
Copy link
Copy Markdown

MarkOdey commented Mar 14, 2017

Well I don't really understand pull requests yet but something went wrong it seems. Also wouldn't it be better to do the fix in the source not the built files.

This actual fix should be done in textangular/src/factories.js at line 231

@bostondevin
Copy link
Copy Markdown
Author

Yeah - all the pull requests to this repo to date have failed - looks like they need to update their package.json or something - I dunno - that should have passed.

@MarkOdey
Copy link
Copy Markdown

Just compiled master and it all passed fine. It could be the node version on the travis-ci service. It's marked as 0.1.
Oh well. Maybe if we could find an administrator to fix this issue.

@Weestdudochnicht
Copy link
Copy Markdown

is this issue fixed now?

@MarkOdey
Copy link
Copy Markdown

Unfortunately not in this repository. It seems that the owner of this repo setup a automated test suite to validate pull requests. However all pull requests fails. It would be awesome that the owner of that repo fixes it because bugs are pilling up! Anyways I just forked the repo and fixed it on my own.

https://github.com/MarkOdey/textAngular

I recommend you fork the repo. If you want to use my version as I can't garantee you it will be latest and bug free.

@Weestdudochnicht
Copy link
Copy Markdown

@MarkOdey thanks for your response. Then i will wait for the fix

@silenceisgolden
Copy link
Copy Markdown

@JoelParke Could we get a new release containing this fix? I'm not really interested in forking just for this fix if a release is incoming. Thanks!

@pbassut
Copy link
Copy Markdown
Contributor

pbassut commented Apr 19, 2017

Hey, sure thing!
Tho, as noted by @MarkOdey. Shouldn't that be done in the actual source files?

@silenceisgolden
Copy link
Copy Markdown

@pbassut Very good point, I had not realized that.

@pbassut
Copy link
Copy Markdown
Contributor

pbassut commented Apr 19, 2017

Yea. I'm fixing the Travis issue.
Meanwhile, let's wait for the PR owner to fix his fix so we can merge it and make a new release

@silenceisgolden
Copy link
Copy Markdown

Please note, this fix does not seem to fix the issue in Firefox but it does fix the issue in Chrome.

@MarkOdey
Copy link
Copy Markdown

MarkOdey commented May 1, 2017

@pbassut my fix is done in the source file. I am not an expert in github so I am not sure how we could fix the pullrequest validator. Can someone get a hold of the owner of the repo?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants