Fix editor losing focus on model change #1458#1472
Fix editor losing focus on model change #1458#1472bostondevin wants to merge 2 commits intotextAngular:masterfrom
Conversation
|
I would suggest changing .+? to .*? (matching 0 or more characters instead of 1 or more characters) so that the regexp will still work as originally intended. |
|
Well I don't really understand pull requests yet but something went wrong it seems. Also wouldn't it be better to do the fix in the source not the built files. This actual fix should be done in textangular/src/factories.js at line 231 |
|
Yeah - all the pull requests to this repo to date have failed - looks like they need to update their package.json or something - I dunno - that should have passed. |
|
Just compiled master and it all passed fine. It could be the node version on the travis-ci service. It's marked as 0.1. |
|
is this issue fixed now? |
|
Unfortunately not in this repository. It seems that the owner of this repo setup a automated test suite to validate pull requests. However all pull requests fails. It would be awesome that the owner of that repo fixes it because bugs are pilling up! Anyways I just forked the repo and fixed it on my own. https://github.com/MarkOdey/textAngular I recommend you fork the repo. If you want to use my version as I can't garantee you it will be latest and bug free. |
|
@MarkOdey thanks for your response. Then i will wait for the fix |
|
@JoelParke Could we get a new release containing this fix? I'm not really interested in forking just for this fix if a release is incoming. Thanks! |
|
Hey, sure thing! |
|
@pbassut Very good point, I had not realized that. |
|
Yea. I'm fixing the Travis issue. |
|
Please note, this fix does not seem to fix the issue in Firefox but it does fix the issue in Chrome. |
|
@pbassut my fix is done in the source file. I am not an expert in github so I am not sure how we could fix the pullrequest validator. Can someone get a hold of the owner of the repo? |
Fix this bug: #1458