Improve default createLink action edition#1494
Open
jgribonvald wants to merge 1 commit intotextAngular:masterfrom
Open
Improve default createLink action edition#1494jgribonvald wants to merge 1 commit intotextAngular:masterfrom
jgribonvald wants to merge 1 commit intotextAngular:masterfrom
Conversation
- on selection we can edit the text link
- on taDropHandler when calling insertAction we can provide an array contaning the url and optionally a text to show instead of the url and css class names as string
example : insertAction('createLink', ['https://ex.edu.fr/files/document.odt', 'document.odt', 'fa fa-file-word-o fa-2x fa-lg' ], true)
and it will create the html tag :
<a href="proxy.php?url=https%3A%2F%2Fwww.github.com%2F%3Ca+href%3D"https://ex.edu.fr/files/document.odt" rel="nofollow">https://ex.edu.fr/files/document.odt" target="_blank"><i class="fa fa-file-word-o fa-2x fa-lg"></i> <span>document.odt</span></a>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
example : insertAction('createLink', ['https://ex.edu.fr/files/document.odt', 'document.odt', 'fa fa-file-word-o fa-2x fa-lg' ], true)
and it will create the html tag :
<a href="proxy.php?url=https%3A%2F%2Fex.edu.fr%2Ffiles%2Fdocument.odt" target="_blank"><i class="fa fa-file-word-o fa-2x fa-lg"></i> <span>document.odt</span></a>