fix (taBind): Fix broken HTML when list elements have an attribute.#1573
Open
davidmdem wants to merge 1 commit intotextAngular:masterfrom
Open
fix (taBind): Fix broken HTML when list elements have an attribute.#1573davidmdem wants to merge 1 commit intotextAngular:masterfrom
davidmdem wants to merge 1 commit intotextAngular:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the formatter in taBind will hard cut off list elements at the 4th character. This means that a
classorstyleattribute can by typed and saved, but when the data is reloaded/bound any attributes are cut off and broken HTML is displayed.This can be reproduced in the
taBind.$formatters.spec.jstests for indenting lists.Adding the following test to the current master branch will reproduce the failure:
The test above and a fix are included in this PR. Thank you!