fix: taTools not available with webpack#1575
Open
vctr-dev wants to merge 9 commits intotextAngular:masterfrom
Open
fix: taTools not available with webpack#1575vctr-dev wants to merge 9 commits intotextAngular:masterfrom
vctr-dev wants to merge 9 commits intotextAngular:masterfrom
Conversation
Add taTools to global scope if it does not already exist. This solves the webpack issue of not being able to find taTools variable. Closes Issue textAngular#1015
Updated the sanitize validStyles function to allow margin, padding, and display as valid styles
Also made precedence a bit more explicit for recently added styles (left originals alone to reduce conflict probability)
I dropped statements in the middle of a set of conditionals; rewritten to fix it.
See cebjyre@0e99b8b for change details
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add taTools to global scope if it does not already exist.
This solves the webpack issue of not being able to find taTools variable.
Closes Issue #1015