Skip to content

reqs: prevent potential int overflow when parsing chunked data #603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rofl0r merged 1 commit into from
Mar 29, 2026
+2 −1
Merged

reqs: prevent potential int overflow when parsing chunked data #603

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/reqs.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -575,7 +575,8 @@ static int pull_client_data_chunked (struct conn_s *connptr) {
}

chunklen = strtol (buffer, (char**)0, 16);
if (chunklen < 0) goto ERROR_EXIT;
/* prevent negative or huge values causing overflow */
if (chunklen < 0 || chunklen > 0x0fffffff) goto ERROR_EXIT;

if (pull_client_data (connptr, chunklen+2) < 0)
goto ERROR_EXIT;
Expand Down
Loading