Track and use last known remote hash in pullv2#5571
Draft
ChrisPenner wants to merge 3 commits intotrunkfrom
Draft
Track and use last known remote hash in pullv2#5571ChrisPenner wants to merge 3 commits intotrunkfrom
ChrisPenner wants to merge 3 commits intotrunkfrom
Conversation
c832639 to
3adfbb6
Compare
3adfbb6 to
1e9cb6c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
TODO: Need to ensure migration happens in create-schema
If we keep track of the last known hash of a remote branch according to the last time we synced with it, we can provide that hash to the server when running syncv2 and it knows which entities we'll need to receive by diffing the two.
Implementation notes
Test coverage