Draft
Conversation
Instead of disabling it project-wide, only do it for the files that trigger it. This makes it easier to fix a single instance at a time.
There is one module that still disables `-Wx-partial`, with a comment that says when it can be fixed.
There are a couple comments in here where we could perhaps avoid converting `NonEmpty` to `[]`, but they lead to some pretty deep cascading changes.
7136ac3 to
4809fc2
Compare
Also remove another `-Wx-partial` that was added on trunk.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
GHC 9.8 added custom warning categories, and 9.10 added warnings to
headandtailin the customx-partialcategory. The upgrade to GHC 9.10 downgradedx-partialso it wouldn’t error. This undoes the downgrading, fixing allx-partialoccurrences.Implementation approach and notes
There are a few different approaches, including
[]toNonEmpty,Cofix ((,) a)), andtailwithdrop 1when appropriate.Interesting/controversial decisions
This expands the
unison-util-recursionpackage slightly, adding corecursion support for the infinite streams. It again raises the question of instead adding a dependency onyayaorrecursion-schemes.Test coverage
This is a refactoring, it should be covered by existing tests.