Improve error message for pattern matching in function definitions#6217
Open
tfausak wants to merge 6 commits intounisonweb:trunkfrom
Open
Improve error message for pattern matching in function definitions#6217tfausak wants to merge 6 commits intounisonweb:trunkfrom
tfausak wants to merge 6 commits intounisonweb:trunkfrom
Conversation
…nisonweb#793) When users attempt Haskell-style pattern matching in function heads (e.g. `isEmpty [] = true`), Unison now reports a clear error explaining that this syntax is not supported and suggests using `case` instead. Co-Authored-By: Claude Opus 4.6 <[email protected]>
Adds `(` to the set of pattern-like tokens, so constructor patterns like `f (Some x) = ...` and tuple patterns like `f (a, b) = ...` are detected inside blocks. The balanced-bracket scanner already handles these correctly. Co-Authored-By: Claude Opus 4.6 <[email protected]>
The error message now shows a contextual example using the function name the user wrote (e.g. "factorial arg = case arg of") instead of a generic hardcoded example. Also simplifies the suggestion to a single branch. Co-Authored-By: Claude Opus 4.6 <[email protected]>
Co-Authored-By: Claude Opus 4.6 <[email protected]>
Co-Authored-By: Claude Opus 4.6 <[email protected]>
Co-Authored-By: Claude Opus 4.6 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #793.