Fix intelgputorch210 Triton dependency for PyTorch 2.10 XPU#4941
Fix intelgputorch210 Triton dependency for PyTorch 2.10 XPU#4941aiSynergy37 wants to merge 1 commit intounslothai:mainfrom
Conversation
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7e30f4300e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "pytorch_triton_xpu @ https://download.pytorch.org/whl/pytorch_triton_xpu-3.5.0-cp311-cp311-win_amd64.whl#sha256=debf75348da8e8c7166b4d4a9b91d1508bb8d6581e339f79f7604b2e6746bacd ; sys_platform == 'win32' and python_version == '3.11' and (platform_machine == 'AMD64' or platform_machine == 'x86_64')", | ||
| "pytorch_triton_xpu @ https://download.pytorch.org/whl/pytorch_triton_xpu-3.5.0-cp312-cp312-win_amd64.whl#sha256=97337a47425f1963a723475bd61037460e84ba01db4f87a1d662c3718ff6c47e ; sys_platform == 'win32' and python_version == '3.12' and (platform_machine == 'AMD64' or platform_machine == 'x86_64')", | ||
| "pytorch_triton_xpu @ https://download.pytorch.org/whl/pytorch_triton_xpu-3.5.0-cp313-cp313-win_amd64.whl#sha256=2caf8138695f6abb023ecd02031a2611ba1bf8fff2f19802567cb2fadefe9e87 ; sys_platform == 'win32' and python_version == '3.13' and (platform_machine == 'AMD64' or platform_machine == 'x86_64')", | ||
| "triton-xpu @ https://download.pytorch.org/whl/triton_xpu-3.6.0-cp310-cp310-manylinux_2_27_x86_64.manylinux_2_28_x86_64.whl ; platform_system == 'Linux' and python_version == '3.10' and platform_machine == 'x86_64'", |
There was a problem hiding this comment.
Restore sha256 pins for triton-xpu wheel URLs
The intelgputorch210 update switches to direct triton-xpu wheel URLs but drops the #sha256=... fragments that were present on the previous Triton entries. That makes this extra non-reproducible and removes integrity verification for these downloads (the same extras block still hashes other pinned wheel URLs), so a changed artifact at the same URL would be accepted silently. Please add sha256 hashes to each new triton-xpu URL.
Useful? React with 👍 / 👎.
7e30f43 to
9d813dd
Compare
What
intelgputorch210extra inpyproject.tomlto usetriton-xpu3.6.0 wheels instead ofpytorch_triton_xpu3.5.0.intelgputorch210block only.Why
Issue #4931 reports that PyTorch 2.10+xpu should use
triton-xpu3.6.0, butintelgputorch210currently pinspytorch_triton_xpu3.5.0. This causes a dependency mismatch for that install target.How
intelgputorch210:pytorch_triton_xpu-3.5.0-*triton_xpu-3.6.0-*Closes #4931