Replaced --no-use-wheel with --no-binary :all: after installing lates…#366
Closed
chgarling wants to merge 6 commits intovoxpupuli:masterfrom
Closed
Replaced --no-use-wheel with --no-binary :all: after installing lates…#366chgarling wants to merge 6 commits intovoxpupuli:masterfrom
chgarling wants to merge 6 commits intovoxpupuli:masterfrom
Conversation
Author
|
Hello, can you find some time to take a look at the outstanding pull requests, please? |
|
I would say you could fork if this becomes an ongoing support issue. This seems like a necessity at this point...anyone using pip v9 or newer cannot do installs now. |
|
@chgarling Can you rebase this on master, as travis should be green now? |
* added ${pip_cmd} install --upgrade pip to have a recent pip version installed, the python::virtualenv function failed with pip 1.4.1
* replaced --no-use-wheel with --no-binary :all: as a dependency of recent pip version
Use actual versions of ruby that are supported, so 2.1.9 instead of 2.1.0 and remove 2.3.1 as it never made it into Puppet v4.
Author
|
@flokli I have rebased my changes on master right now. Please, can you check if its fine now, or if I have to do something else? I was not sure, if I need to create a new pull request after rebasing. |
|
@chgarling you could simply squasch and force-push to the branch of this PR, but now this can also be squashed during merge. ping @ghoneycutt |
This was referenced Apr 16, 2018
Collaborator
|
Replaced with #388 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…t pip version