Conversation
There was a problem hiding this comment.
Pull request overview
Updates build and CI configuration to run the project on Java 25 by making Immutables annotation processing explicit and centralizing its version management.
Changes:
- Add
immutables.versionproperty in the parent POM and reuse it indocker-java-transport. - Configure Maven Compiler Plugin
annotationProcessorPathsto include Immutables. - Extend GitHub Actions CI matrix to include Java 25.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| pom.xml | Adds immutables.version and globally configures compiler annotation processor path. |
| docker-java-transport/pom.xml | Switches Immutables dependency version to the shared property. |
| .github/workflows/ci.yml | Adds Java 25 to the CI build matrix. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <hamcrest.jpa-matchers>1.8</hamcrest.jpa-matchers> | ||
| <lambdaj.version>2.3.3</lambdaj.version> | ||
| <mockito.version>3.3.0</mockito.version> | ||
|
|
There was a problem hiding this comment.
There’s trailing whitespace on this otherwise blank line; please remove it to keep the POM clean and avoid noisy diffs.
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <path> | ||
| <groupId>org.projectlombok</groupId> | ||
| <artifactId>lombok</artifactId> | ||
| <version>${lombok.version}</version> | ||
| </path> |
There was a problem hiding this comment.
maven-compiler-plugin is configured with an annotation processor path that references ${lombok.version}, but that property is not defined anywhere in the parent POM (and Lombok deps in modules currently hardcode 1.18.38). This will make Maven fail to resolve the annotationProcessorPaths. Define lombok.version in the parent POM (or switch the processor path to the same explicit version used by modules) and ideally reuse the same property everywhere to avoid version skew.
This change is