Skip to content

Run with Java 25 #2538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eddumelendez wants to merge 6 commits into
base: main
Choose a base branch
from
+16 −1
Open

Run with Java 25 #2538

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5233ae7
Run with Java 25
eddumelendez Nov 3, 2025
d11914c
Add org.immutables:value as an annotation processor
eddumelendez Nov 3, 2025
edbbd36
Merge branch 'main' into java-25
eddumelendez Mar 5, 2026
728021b
Merge branch 'main' into java-25
eddumelendez Mar 5, 2026
cd0ab9e
Merge branch 'main' into java-25
eddumelendez Mar 27, 2026
aeb2769
Apply suggestions from code review
eddumelendez Mar 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ jobs:
- { name: "default", javaVersion: 8 }
- { name: "default", javaVersion: 17 }
- { name: "default", javaVersion: 21 }
- { name: "default", javaVersion: 25 }
steps:
- uses: actions/checkout@v6
- name: Set up JDK
Expand Down
2 changes: 1 addition & 1 deletion docker-java-transport/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
<dependency>
<groupId>org.immutables</groupId>
<artifactId>value</artifactId>
<version>2.10.1</version>
<version>${immutables.version}</version>
<scope>provided</scope>
</dependency>

Expand Down
14 changes: 14 additions & 0 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,8 @@
<hamcrest.jpa-matchers>1.8</hamcrest.jpa-matchers>
<lambdaj.version>2.3.3</lambdaj.version>
<mockito.version>3.3.0</mockito.version>

Copy link

Copilot AI Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There’s trailing whitespace on this otherwise blank line; please remove it to keep the POM clean and avoid noisy diffs.

Suggested change

Copilot uses AI. Check for mistakes.
<immutables.version>2.10.1</immutables.version>


<maven-jar-plugin.version>3.0.2</maven-jar-plugin.version>
Expand Down Expand Up @@ -147,6 +149,18 @@
<debug>${jdk.debug}</debug>
<optimize>${jdk.optimize}</optimize>
<parameters>true</parameters>
<annotationProcessorPaths>
<path>
<groupId>org.immutables</groupId>
<artifactId>value</artifactId>
<version>${immutables.version}</version>
</path>
<path>
<groupId>org.projectlombok</groupId>
<artifactId>lombok</artifactId>
<version>${lombok.version}</version>
</path>
Comment on lines +158 to +162
Copy link

Copilot AI Mar 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maven-compiler-plugin is configured with an annotation processor path that references ${lombok.version}, but that property is not defined anywhere in the parent POM (and Lombok deps in modules currently hardcode 1.18.38). This will make Maven fail to resolve the annotationProcessorPaths. Define lombok.version in the parent POM (or switch the processor path to the same explicit version used by modules) and ideally reuse the same property everywhere to avoid version skew.

Copilot uses AI. Check for mistakes.
</annotationProcessorPaths>
</configuration>
</plugin>

Expand Down
Loading