Merged
Conversation
The defualt log level was previously set to WARN, meaning INFO-level logging and above would not be output. This was confusing, as INFO statements were intended to be used to convey basic, helpful information. To that end, the default level has been dropped down to INFO. This also required updating log.info statements that were outputting DEBUG-style information to be similarly adjusted to log.debug statements.
Having this as a WARN-level log statement is overly aggressive. No exceptions were thrown, and skipping a non-existant directory is expected behavior, thus this statement is downgraded to DEBUG-level.
Make INFO the default log level
Updated to pom-scijava 5.3.3
Signed-off-by: Jenkins <[email protected]>
Also add API for setting the strictness later, if desired. This will be useful so that we can behave strictly (or not) in later situations, particularly during context injection.
This will enable subsequent changes to the error handling of those respective methods.
When Context#inject(Object) is called, there are all kinds of crazy things that can potentially happen, particularly class loading failures (e.g., NoClassDefFoundError) due to missing dependencies when scanning the given object's fields and methods. When the context is in non-strict mode, we want to try very hard not to throw an exception, but instead simply log an error, when something goes wrong during the injection. And we want the injection to proceed tenaciously, so that if something goes wrong at one stage, other stages still might complete successfully. This commit is best viewed with git's "-b" flag.
This branch makes the SciJava application framework try harder to keep going when something goes wrong during context injection while in non-strict mode. The idea is that it might help applications succeed in starting up when they otherwise would have failed with an exception. In practice, it is still a crapshoot, since the normal assumptions about which fields have been successfully injected no longer hold while in non-strict mode; consequently, subsequent NPEs are much more likely.
Migrated from the imglib2-meta project.
Add a Named interface for things with names. This was originally part of the imglib2-meta project (and later migrated to imagej-common as a deprecated class). But it really fits best here in the SciJava Common library.
Signed-off-by: Jenkins <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.