This repository was archived by the owner on Apr 15, 2024. It is now read-only.
Closed
Conversation
Ccf 9171 memory vcpu mismatch (#155) * don't use default command line params for memory and vcpus * 0.12.9 Bump lodash for vunerabilities CCF-9252 update generator for linux CCF-9376 update generator version to 0.3.18 (#163) CCF-9286: return instanceId in the message when promoting a snapshot … (#162) * CCF-9286: return instanceId in the message when promoting a snapshot to an environment that was being returned by the api response but not getting included in the cli response * updated message with review comments fixing undefined error when promoting a snapshot to an environment, instanceId is under `response.message.instanceId` (#164) working recursive upload of directory (#165) * working recursive upload of directory * 0.12.12 Remove cortex-processors commands (#166) Add agents list-snapshot-instances (#168) Chunk directory upload (#169) * use sequential chunks of files to upload * 0.12.13 Fix invalid query param on list snap instances (#170) Updated list-services command to display the parameter names/types as well (#171) CCF-9783 reverting changes to agent and catalog (#173) Remove --timeout option from actions deploy (#175) Ccf 9955 configure url (#176) * add protocol prefix if one is missing * 0.12.14 Return error message from content upload properly Bump generator-cortex to pick up with_type change created template checklist as POC updated pull_request_template Update pull_request_template.md
cdraper-CS
approved these changes
Apr 18, 2019
Contributor
|
Develop inevitably ended up out of sync from master because of the merge commits into master due to PRs. The hope is that if we always do 'rebase' for PRs, it will remain in sync but to test that we would first need to force-push master to develop to get them back in sync. And I believe there's no way to stop people accidentally doing a different style of merge for the PRs |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From what I can see,
developandmasterdiverged at commit65b3919made against master, not part of thedevelopbranch.So all commits to develop since the commit previous to it (
897ca9f) are divorced from themasterbranch.In order to have the latest dev (this release) be mergeable to
master, I did a squash of all the commits from5c30f1f(the point at which develop and master bifurcate) on this branch and rebased onmaster. So this PR merges fine. I verified thatgit diff develop masteris the same asgit diff release0.12.14-b master.This hack only allows us to merge the latest changes in develop to master for the release, but develop is still out of sync with master. We'll have to fix this for real. If you guys think this is too ugly and we need to fix it for realz before the release, give me ideas. Thanks!
Changes
Ccf 9171 memory vcpu mismatch (#155)
don't use default command line params for memory and vcpus
0.12.9
Bump lodash for vunerabilities
CCF-9252 update generator for linux
CCF-9376 update generator version to 0.3.18 (#163)
CCF-9286: return instanceId in the message when promoting a snapshot … (#162)
CCF-9286: return instanceId in the message when promoting a snapshot to an environment that was being returned by the api response but not getting included in the cli response
updated message with review comments
fixing undefined error when promoting a snapshot to an environment, instanceId is under
response.message.instanceId(#164)working recursive upload of directory (#165)
working recursive upload of directory
0.12.12
Remove cortex-processors commands (#166)
Add agents list-snapshot-instances (#168)
Chunk directory upload (#169)
use sequential chunks of files to upload
0.12.13
Fix invalid query param on list snap instances (#170)
Updated list-services command to display the parameter names/types as well (#171)
CCF-9783 reverting changes to agent and catalog (#173)
Remove --timeout option from actions deploy (#175)
Ccf 9955 configure url (#176)
add protocol prefix if one is missing
0.12.14
Return error message from content upload properly
Bump generator-cortex to pick up with_type change
created template checklist as POC
updated pull_request_template
Update pull_request_template.md
Checklist:
Please check you fulfill ALL of the relevant checkboxes
npm testand it passes