Skip to content
This repository was archived by the owner on Apr 15, 2024. It is now read-only.

Release 0.12.14 b#181

Closed
vadan-cs wants to merge 1 commit intomasterfrom
release0.12.14-b
Closed

Release 0.12.14 b#181
vadan-cs wants to merge 1 commit intomasterfrom
release0.12.14-b

Conversation

@vadan-cs
Copy link
Copy Markdown
Contributor

@vadan-cs vadan-cs commented Apr 18, 2019

From what I can see, develop and master diverged at commit 65b3919 made against master, not part of the develop branch.
So all commits to develop since the commit previous to it (897ca9f) are divorced from the master branch.
In order to have the latest dev (this release) be mergeable to master, I did a squash of all the commits from 5c30f1f (the point at which develop and master bifurcate) on this branch and rebased on master. So this PR merges fine. I verified that git diff develop master is the same as git diff release0.12.14-b master.

This hack only allows us to merge the latest changes in develop to master for the release, but develop is still out of sync with master. We'll have to fix this for real. If you guys think this is too ugly and we need to fix it for realz before the release, give me ideas. Thanks!

Changes

Ccf 9171 memory vcpu mismatch (#155)

  • don't use default command line params for memory and vcpus

  • 0.12.9

Bump lodash for vunerabilities
CCF-9252 update generator for linux

CCF-9376 update generator version to 0.3.18 (#163)

CCF-9286: return instanceId in the message when promoting a snapshot … (#162)

  • CCF-9286: return instanceId in the message when promoting a snapshot to an environment that was being returned by the api response but not getting included in the cli response

  • updated message with review comments

fixing undefined error when promoting a snapshot to an environment, instanceId is under response.message.instanceId (#164)

working recursive upload of directory (#165)

  • working recursive upload of directory

  • 0.12.12

Remove cortex-processors commands (#166)

Add agents list-snapshot-instances (#168)

Chunk directory upload (#169)

  • use sequential chunks of files to upload

  • 0.12.13

Fix invalid query param on list snap instances (#170)

Updated list-services command to display the parameter names/types as well (#171)

CCF-9783 reverting changes to agent and catalog (#173)

Remove --timeout option from actions deploy (#175)

Ccf 9955 configure url (#176)

  • add protocol prefix if one is missing

  • 0.12.14

Return error message from content upload properly

Bump generator-cortex to pick up with_type change

created template checklist as POC

updated pull_request_template

Update pull_request_template.md

Checklist:

Please check you fulfill ALL of the relevant checkboxes

  • Notified docs of any potential USER-facing changes
  • Added short description of the change - with relevant motivation and context.
  • Branch has the ticket number in its name (along with a ticket summary)
  • Commented the code, particularly in hard-to-understand areas
  • Added tests that prove my fix is effective or that my feature works
  • Ran npm test and it passes
  • Changes generate no new warnings

Ccf 9171 memory vcpu mismatch (#155)

* don't use default command line params for memory and vcpus

* 0.12.9

Bump lodash for vunerabilities
CCF-9252 update generator for linux

CCF-9376 update generator version to 0.3.18 (#163)

CCF-9286: return instanceId in the message when promoting a snapshot … (#162)

* CCF-9286: return instanceId in the message when promoting a snapshot to an environment that was being returned by the api response but not getting included in the cli response

* updated message with review comments

fixing undefined error when promoting a snapshot to an environment, instanceId is under `response.message.instanceId` (#164)

working recursive upload of directory (#165)

* working recursive upload of directory

* 0.12.12

Remove cortex-processors commands (#166)

Add agents list-snapshot-instances (#168)

Chunk directory upload (#169)

* use sequential chunks of files to upload

* 0.12.13

Fix invalid query param on list snap instances (#170)

Updated list-services command to display the parameter names/types as well (#171)

CCF-9783 reverting changes to agent and catalog (#173)

Remove --timeout option from actions deploy (#175)

Ccf 9955 configure url (#176)

* add protocol prefix if one is missing

* 0.12.14

Return error message from content upload properly

Bump generator-cortex to pick up with_type change

created template checklist as POC

updated pull_request_template

Update pull_request_template.md
Copy link
Copy Markdown
Contributor

@daldridge-cs daldridge-cs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cdraper-CS
Copy link
Copy Markdown
Contributor

Develop inevitably ended up out of sync from master because of the merge commits into master due to PRs. The hope is that if we always do 'rebase' for PRs, it will remain in sync but to test that we would first need to force-push master to develop to get them back in sync. And I believe there's no way to stop people accidentally doing a different style of merge for the PRs

@vadan-cs vadan-cs changed the title Release 0.12.14 Release 0.12.14 b Apr 18, 2019
@vadan-cs vadan-cs mentioned this pull request Apr 18, 2019
@vadan-cs vadan-cs closed this Apr 22, 2019
@jgielstra-cs jgielstra-cs deleted the release0.12.14-b branch June 11, 2019 19:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants