This repository was archived by the owner on Apr 15, 2024. It is now read-only.
Merged
Conversation
CCF-9252 update generator for linux
#162) * CCF-9286: return instanceId in the message when promoting a snapshot to an environment that was being returned by the api response but not getting included in the cli response * updated message with review comments
…nstanceId is under `response.message.instanceId` (#164)
* working recursive upload of directory * 0.12.12
* use sequential chunks of files to upload * 0.12.13
* add protocol prefix if one is missing * 0.12.14
AgrimAsthana-CS
approved these changes
Apr 22, 2019
Contributor
AgrimAsthana-CS
left a comment
There was a problem hiding this comment.
Not critical but by convention.. PULL_REQUEST_TEMPLATE.md is normally placed inside a .github folder at the root of a git repo.. looks good to merge otherwise.
clee-cs
approved these changes
Apr 22, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ok I think this is a better PR. It's develop rebased on master, but without squashing so we don't loose the commit history. So
release0.12.14-c==develop-rebased-master.We can force set the
developto this hash and go from there.Here's the previous PR for reference #181