Allow ignoring errors occurring while moving tooltip#165
Closed
TeaDrivenDev wants to merge 1 commit intoControlzEx:developfrom
Closed
Allow ignoring errors occurring while moving tooltip#165TeaDrivenDev wants to merge 1 commit intoControlzEx:developfrom
TeaDrivenDev wants to merge 1 commit intoControlzEx:developfrom
Conversation
Member
|
Could you add the full stacktrace? |
Contributor
Author
|
Sure! Full thing |
Member
|
That even stranger. What we can do here, and what i would prefer instead of a new property, is to add a simple check for a valid presentation source before we try to move anything. |
Contributor
Author
|
That makes sense. I have created #166 to replace this, as the change is now completely different. We will look into reporting the issue to WPF and DevExpress. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the changes you have made to improve this project
This PR adds a DependencyProperty to
ToolTipAssistto allow ignoring any exceptions that occur in the moving logic.Unit test
None.
Additional context
We are using the automove tooltip from ControlzEx in a few places. Some of our users don't use the application on their own machines, but rather connect to their environment via RDP and Citrix. When the RDP connection is closed after using the application for a while, and later reconnected, the application occasionally crashes with the following exception:
(stacktrace truncated, because it's long and all WPF and probably not useful beyond this part)
We haven't been able to reproduce the issue in a controlled environment, but we have a number of error reports regarding this from users.
I have chosen to run the entire move logic within the
try/catchif errors are ignored, because it's cleaner code than just handling it for a single line, and no errors in something as inconsequential as a tooltip should bring down the application, regardless of the source.Open question: What (if anything) should the
catchblock trace?Closed Issues
None.