Check for PresentationSource before attempting to move tooltip#166
Merged
batzen merged 2 commits intoControlzEx:developfrom Oct 17, 2022
Merged
Conversation
Member
|
I guess the check should be added to the protective checks at the method beginning. |
Contributor
Author
|
Yeah, that makes sense. Reads more cleanly too. Updated. |
Member
|
Thanks for contributing! |
Contributor
Author
|
Thanks! What is the best way for us to get this into production quickly to fix the crashes for our users? |
Member
|
@TeaDrivenDev If you are using still the v5 then we can add this fix to this version as a hotfix. |
Contributor
Author
|
@punker76 Yes, we are currently on 5.0.1. If a hotfix is possible, that would be much appreciated. |
punker76
pushed a commit
that referenced
this pull request
Oct 20, 2022
Check for PresentationSource before attempting to move tooltip
Member
|
@TeaDrivenDev done |
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the changes you have made to improve this project
This PR adds a check for a PresentationSource connected to the PlacementTarget before trying to move a tooltip, as suggested in #165.
Unit test
None.
Additional context
We are using the automove tooltip from ControlzEx in a few places. Some of our users don't use the application on their own machines, but rather connect to their environment via RDP and Citrix. When the RDP connection is closed after using the application for a while, and later reconnected, the application occasionally crashes with the following exception:
Full stacktrace
We haven't been able to reproduce the issue in a controlled environment, but we have a number of error reports regarding this from users.
Closed Issues
None.