create-unit: bug fixes and update#52
create-unit: bug fixes and update#52lethosor merged 3 commits intoDFHack:masterfrom AtomicChicken:create-unit
Conversation
AtomicChicken
commented
May 7, 2018
- creatures of the appropriate age are now spawned as babies or children where applicable
- fix: civ_id is now properly assigned to historical_figure, resolving several hostility issues (spawned pets are no longer attacked by fortress military!)
- fix: unnamed creatures are no longer spawned with a string of numbers as a first name
- creatures of the appropriate age are now spawned as babies or children where applicable - fix: civ_id is now properly assigned to historical_figure, resolving several hostility issues (spawned pets are no longer attacked by fortress military!) - fix: unnamed creatures are no longer spawned with a string of numbers as a first name
| u.animal.population.population_idx = -1 | ||
| u.animal.population.depth = -1 | ||
|
|
||
| u.counters.soldier_mood_countdown = -1 |
There was a problem hiding this comment.
Which change is this related to? This section was last changed in 96b118b, which led to the merge conflict here, but I can't imagine the first two fields here (at least) corresponding to the bugs you fixed.
There was a problem hiding this comment.
And for reference, the rest of this section dates back to the initial commit of this script (only the field names were changed recently)
There was a problem hiding this comment.
To clarify, I did not remove this section, but simply relocated it from the domesticate() function to line 552. This is because, as far as I can tell, these changes should apply to all units, not just tamed creatures.
|
Just so you know if you try to push more changes - I used the "resolve conflicts" button here, which made a new commit, so be sure to pull that. |