Conversation
|
Looks good to me, does this depend on any other PRs? |
|
Partly.
The regular launch files I could change it to only be a PR for the Gazebo-ROS2 bridge. |
|
Either is fine, if you make the other PR we can get it merged in and then merge this one. Please tag the other PR here as a comment when you make it :) Other than that, you mention to use /namespace/odom instead of the FMU ones. Is it optional? |
| maintainer_email='[email protected]', | ||
| description='simple SITL launch files for single- and multi-agent simulation of the ATMOS platform', | ||
| license='BSD 3-Clause', | ||
| tests_require=['pytest'], |
There was a problem hiding this comment.
I believe tests_require=['pytest'] is outdated in setuptools and therefore gives warnings when building. I think it should be changed to
extras_require={
'test': ['pytest']
}
I'll verify and update it.
|
I will do a couple of updates to this PR. I'll let you know when it is ready for review and merge again. |
|
Sounds good! |
|
Okay, @Pedro-Roque, it is ready for review.
I have not changed any functionality of the original launch scripts. |
This PR adds:
/namespace/odomfrom Gazebo instead of usingvehicle_attitudeandvehicle_local_position.kth_space_labworld.