Use "function" instead of "method" where appropriate#496
Merged
aniav merged 1 commit intoDjangoGirls:masterfrom Oct 19, 2015
Merged
Use "function" instead of "method" where appropriate#496aniav merged 1 commit intoDjangoGirls:masterfrom
aniav merged 1 commit intoDjangoGirls:masterfrom
Conversation
Member
There was a problem hiding this comment.
post_list is a method. No need to change the first one ;)
Contributor
Author
There was a problem hiding this comment.
In Python terms, it's not a method: https://docs.python.org/2/tutorial/classes.html#method-objects
Contributor
Author
There was a problem hiding this comment.
Correct me if I'm wrong, if it's a method, to what class does it belong?
Member
There was a problem hiding this comment.
Ah, sorrry! I messed this in my head with the class based views. You are totally right, thank you for correcting me!
aniav
added a commit
that referenced
this pull request
Oct 19, 2015
Use "function" instead of "method" where appropriate
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.