Skip to content

Use "function" instead of "method" where appropriate #496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aniav merged 1 commit into from
Oct 19, 2015
Merged

Use "function" instead of "method" where appropriate #496

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion en/django_urls/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ from django.conf.urls import url
from . import views
```

Here we're just importing Django's methods and all of our `views` from `blog` application (we don't have any yet, but we will get to that in a minute!)
Here we're importing Django's function `url` and all of our `views` from `blog` application (we don't have any yet, but we will get to that in a minute!)

After that, we can add our first URL pattern:

Expand Down
4 changes: 2 additions & 2 deletions en/django_views/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

Time to get rid of the bug we created in the last chapter :)

A *view* is a place where we put the "logic" of our application. It will request information from the `model` you created before and pass it to a `template`. We'll create a template in the next chapter. Views are just Python methods that are a little bit more complicated than the ones we wrote in the __Introduction to Python__ chapter.
A *view* is a place where we put the "logic" of our application. It will request information from the `model` you created before and pass it to a `template`. We'll create a template in the next chapter. Views are just Python functions that are a little bit more complicated than the ones we wrote in the __Introduction to Python__ chapter.

Views are placed in the `views.py` file. We will add our *views* to the `blog/views.py` file.

Expand All @@ -25,7 +25,7 @@ def post_list(request):
```


As you can see, we created a method (`def`) called `post_list` that takes `request` and `return` a method `render` that will render (put together) our template `blog/post_list.html`.
As you can see, we created a function (`def`) called `post_list` that takes `request` and `return` a function `render` that will render (put together) our template `blog/post_list.html`.
Copy link
Copy Markdown
Member

@aniav aniav Oct 19, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

post_list is a method. No need to change the first one ;)

Copy link
Copy Markdown
Contributor Author

@domenkozar domenkozar Oct 19, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In Python terms, it's not a method: https://docs.python.org/2/tutorial/classes.html#method-objects

Copy link
Copy Markdown
Contributor Author

@domenkozar domenkozar Oct 19, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct me if I'm wrong, if it's a method, to what class does it belong?

Copy link
Copy Markdown
Member

@aniav aniav Oct 19, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, sorrry! I messed this in my head with the class based views. You are totally right, thank you for correcting me!

Copy link
Copy Markdown
Contributor Author

@domenkozar domenkozar Oct 19, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍰


Save the file, go to http://127.0.0.1:8000/ and see what we have got.

Expand Down