Skip to content

refactor: replace AssetsManager by ResourceManager to use entt resource cache#144

Merged
Miou-zora merged 20 commits intomainfrom
143-refactor-assetsmanager-to-use-entt-resource-cache
Apr 1, 2025
Merged

refactor: replace AssetsManager by ResourceManager to use entt resource cache#144
Miou-zora merged 20 commits intomainfrom
143-refactor-assetsmanager-to-use-entt-resource-cache

Conversation

@MasterLaplace
Copy link
Contributor

@MasterLaplace MasterLaplace commented Mar 25, 2025 •
edited
Loading

Related to:

Rename AssetsManager to ResourceManager.
Use entt::resource_cache to store ResourceType instead of std::unordered_map.

@MasterLaplace MasterLaplace linked an issue Mar 25, 2025 that may be closed by this pull request
Refactor AssetsManager to use entt resource cache #143
Closed
@MasterLaplace MasterLaplace self-assigned this Mar 25, 2025
@MasterLaplace MasterLaplace requested a review from a team March 25, 2025 10:48
@MasterLaplace MasterLaplace added the refactor Code Refactor label Mar 25, 2025
Miou-zora
Miou-zora reviewed Mar 26, 2025
View reviewed changes
Copy link
Contributor

@Miou-zora Miou-zora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This make resources so much cleaner to handle :)

Miou-zora
Miou-zora requested changes Mar 26, 2025
View reviewed changes
Copy link
Contributor

@Miou-zora Miou-zora left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This make resources so much cleaner to handle :)
But I have some interrogations :(

@MasterLaplace MasterLaplace requested a review from Miou-zora March 29, 2025 15:45
@ripel2 @github-actions @MasterLaplace
feat(Text): text rendering using OpenGL (#145)
5268c2d 
Related to:
- #38

![image](https://github.com/user-attachments/assets/be22a7a3-d65b-4692-902b-c5a7faa1b62e)

Can be tested on
[OpenGL-Example/text-rendering](https://github.com/EngineSquared/OpenGL-Example/tree/text-rendering)

Notes:
- Font paths are relative to the project, system-wide fonts are not
supported (there are different APIs for each platform, should be done in
a new issue)
- The text component contains too much information but we are lacking
components for 2D transforms
- Kerning is hard to get right so it is not implemented for now

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@MasterLaplace MasterLaplace force-pushed the 143-refactor-assetsmanager-to-use-entt-resource-cache branch from e9a4f99 to 5268c2d Compare March 29, 2025 19:17
@MasterLaplace MasterLaplace force-pushed the 143-refactor-assetsmanager-to-use-entt-resource-cache branch from 20f2756 to bcfb4bf Compare April 1, 2025 03:09
@Miou-zora Miou-zora enabled auto-merge (squash) April 1, 2025 14:05
@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 1, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Miou-zora Miou-zora merged commit debeb42 into main Apr 1, 2025
12 checks passed
@Miou-zora Miou-zora deleted the 143-refactor-assetsmanager-to-use-entt-resource-cache branch April 1, 2025 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Miou-zora Miou-zora Miou-zora approved these changes

Assignees

@MasterLaplace MasterLaplace

Labels

refactor Code Refactor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Refactor AssetsManager to use entt resource cache

3 participants

@MasterLaplace @Miou-zora @ripel2