Merged
Conversation
TheConnMan
suggested changes
Oct 14, 2016
| def exception_event(exception, klass = nill, uri = nil, controller = nil, action = nil) | ||
| server_interaction { netuitivedServer.exceptionEvent(exception, klass, uri, controller, action) } | ||
| def exception_event(exception, klass = nil, tags = nil) | ||
| server_interaction { netuitivedServer.exceptionEvent(exception, klass, tags) } |
Contributor
There was a problem hiding this comment.
Does netuitive_ruby_api need to be refactored to handle this refactoring? exceptionEvent still uses URI and controller.
Contributor
There was a problem hiding this comment.
Redacting this comment, this function is the function I thought needed to be refactored.
TheConnMan
approved these changes
Oct 14, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #11