Skip to content

exception event refactoring #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jking-netuitive merged 1 commit into from
Oct 14, 2016
Merged

exception event refactoring #12

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lib/netuitive_ruby_api.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,15 +37,15 @@ def clear_metrics
end

def interval
server_interaction { netuitivedServer.interval }
netuitivedServer.interval # synchronous for return value
end

def event(message, timestamp = Time.new, title = 'Ruby Event', level = 'Info', source = 'Ruby Agent', type = 'INFO', tags = nil)
server_interaction { netuitivedServer.event(message, timestamp, title, level, source, type, tags) }
end

def exception_event(exception, klass = nill, uri = nil, controller = nil, action = nil)
server_interaction { netuitivedServer.exceptionEvent(exception, klass, uri, controller, action) }
def exception_event(exception, klass = nil, tags = nil)
server_interaction { netuitivedServer.exceptionEvent(exception, klass, tags) }
Copy link
Copy Markdown
Contributor

@TheConnMan TheConnMan Oct 14, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does netuitive_ruby_api need to be refactored to handle this refactoring? exceptionEvent still uses URI and controller.

Copy link
Copy Markdown
Contributor

@TheConnMan TheConnMan Oct 14, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Redacting this comment, this function is the function I thought needed to be refactored.

end

def stop_server
Expand Down