Add support for \\wsl$\ubuntu path#10674
Merged
adityapatwardhan merged 6 commits intoPowerShell:masterfrom Oct 8, 2019
Merged
Conversation
iSazonov
reviewed
Oct 2, 2019
iSazonov
reviewed
Oct 3, 2019
rjmholt
approved these changes
Oct 3, 2019
Collaborator
rjmholt
left a comment
There was a problem hiding this comment.
Would be nice if we could have tests for this in an image with WSL
Co-Authored-By: Ilya <[email protected]>
iSazonov
approved these changes
Oct 4, 2019
Collaborator
|
@rjmholt It seems your account lost permissions. |
Collaborator
Apparently that's intended since I'm not a maintainer |
Collaborator
|
@rjmholt I see the same for Paul account. But previously approve had green label. |
Member
Author
|
@rjmholt not a maintainer... yet |
iSazonov
approved these changes
Oct 5, 2019
adityapatwardhan
requested changes
Oct 7, 2019
TravisEz13
approved these changes
Oct 7, 2019
adityapatwardhan
approved these changes
Oct 8, 2019
Collaborator
Yeah, the permissions have been updated so that non-maintainers can't give merge-permitting approval, and there are a few of us on the PowerShell team who aren't maintainers (which makes sense to me -- they're different hats to wear). |
|
🎉 Handy links: |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
WSL2 introduces a new filesystem path to access the Linux filesystem from Windows. Depending on the distro name, it would look like
\\wsl$\ubuntu. The problem is that this is not a valid UNC path so it gets rejected outright.Fix is to check for this type of path and pass it off as a UNC path so that the filesystemprovider accepts it as a valid filesystem path. The .NET APIs handle this just fine once it makes it that far into the code.
Manually validated
dir \\wsl$\ubuntuandcd \\wsl$\ubuntu; dirPR Context
Fix #10360
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.