Skip to content

Add support for \\wsl$\ubuntu path #10674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adityapatwardhan merged 6 commits into from
Oct 8, 2019
Merged

Add support for \\wsl$\ubuntu path #10674

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f31dcac
add support for \\wsl$\ubuntu path
SteveL-MSFT Oct 1, 2019
a7a6de8
address codefactor issue
SteveL-MSFT Oct 1, 2019
314f3d7
change from regex to string comparison as there aren't other known sp…
SteveL-MSFT Oct 2, 2019
8555d39
Update src/System.Management.Automation/engine/Utils.cs
SteveL-MSFT Oct 3, 2019
4ef74c4
address Dan's feedback
SteveL-MSFT Oct 4, 2019
355c0de
address Aditya's feedback
SteveL-MSFT Oct 8, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion src/System.Management.Automation/engine/Utils.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1260,8 +1260,19 @@ internal static bool PathIsUnc(string path)
#if UNIX
return false;
#else
if (string.IsNullOrEmpty(path) || !path.StartsWith('\\'))
{
return false;
}

// handle special cases like \\wsl$\ubuntu which isn't a UNC path, but we can say it is so the filesystemprovider can use it
if (path.StartsWith(@"\\wsl$", StringComparison.OrdinalIgnoreCase))
{
return true;
}

Uri uri;
return !string.IsNullOrEmpty(path) && Uri.TryCreate(path, UriKind.Absolute, out uri) && uri.IsUnc;
return Uri.TryCreate(path, UriKind.Absolute, out uri) && uri.IsUnc;
#endif
}

Expand Down