Take ComputerName via Pipeline in Get-HotFix#10852
Merged
iSazonov merged 9 commits intoPowerShell:masterfrom Nov 1, 2019
Merged
Take ComputerName via Pipeline in Get-HotFix#10852iSazonov merged 9 commits intoPowerShell:masterfrom
iSazonov merged 9 commits intoPowerShell:masterfrom
Conversation
Contributor
Author
|
Pester tests has to be added, but would like to get comments on the code changes before that. |
iSazonov
reviewed
Oct 20, 2019
src/Microsoft.PowerShell.Commands.Management/commands/management/Hotfix.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.PowerShell.Commands.Management/commands/management/Hotfix.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.PowerShell.Commands.Management/commands/management/Hotfix.cs
Outdated
Show resolved
Hide resolved
iSazonov
reviewed
Oct 21, 2019
src/Microsoft.PowerShell.Commands.Management/commands/management/Hotfix.cs
Outdated
Show resolved
Hide resolved
Collaborator
|
Please look CodeFactor issues and add tests. |
Contributor
Author
|
@iSazonov sure, but I don't know hot fix the 3rd finding in code factor ( |
Collaborator
|
@kvprasoon Please ignore |
iSazonov
reviewed
Oct 23, 2019
test/powershell/Modules/Microsoft.PowerShell.Management/Get-HotFix.Tests.ps1
Outdated
Show resolved
Hide resolved
iSazonov
approved these changes
Oct 23, 2019
Collaborator
|
@SteveL-MSFT Could you please review? Also we need new Help FWLink for the cmdlet /cc @sdwheeler |
SteveL-MSFT
approved these changes
Oct 30, 2019
Collaborator
|
@SteveL-MSFT New FWLink for Get-Hotfix https://go.microsoft.com/fwlink/?linkid=2109716
|
SteveL-MSFT
requested changes
Oct 30, 2019
Member
SteveL-MSFT
left a comment
There was a problem hiding this comment.
@kvprasoon can you update the fwlink? You'll also need to update a test csv file
Collaborator
|
It is V2Cmdlets.csv file. |
Contributor
Author
|
@SteveL-MSFT I've updated the FWLink. @iSazonov Thanks for letting me know the filename. |
SteveL-MSFT
approved these changes
Oct 31, 2019
Collaborator
|
@kvprasoon Thanks for your contribution! |
|
🎉 Handy links: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Get-HotFix support accepting
-ComputerNamevia pipeline but when used it doesn't consider computers other than localhost.PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.