Skip to content

Take ComputerName via Pipeline in Get-HotFix #10852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iSazonov merged 9 commits into from
Nov 1, 2019
Merged

Take ComputerName via Pipeline in Get-HotFix #10852

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
c2ddcf8
add process record for het-hotfix
kvprasoon Oct 20, 2019
b69992b
code factor fixes
kvprasoon Oct 20, 2019
cc00a6d
changes as per review comments
kvprasoon Oct 20, 2019
25fd909
move connection options to Begin method
kvprasoon Oct 21, 2019
52f0323
changes as per codacy comment
kvprasoon Oct 21, 2019
f1fa4f6
code factor fixes
kvprasoon Oct 22, 2019
556b4bf
add tests
kvprasoon Oct 22, 2019
363516f
check errorID instead of exception message in test
kvprasoon Oct 23, 2019
d4bce7c
update new FWLink
kvprasoon Oct 31, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
61 changes: 36 additions & 25 deletions src/Microsoft.PowerShell.Commands.Management/commands/management/Hotfix.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ namespace Microsoft.PowerShell.Commands
/// Cmdlet for Get-Hotfix Proxy.
/// </summary>
[Cmdlet(VerbsCommon.Get, "HotFix", DefaultParameterSetName = "Default",
HelpUri = "https://go.microsoft.com/fwlink/?LinkID=135217", RemotingCapability = RemotingCapability.SupportedByCommand)]
HelpUri = "https://go.microsoft.com/fwlink/?linkid=2109716", RemotingCapability = RemotingCapability.SupportedByCommand)]
[OutputType(@"System.Management.ManagementObject#root\cimv2\Win32_QuickFixEngineering")]
public sealed class GetHotFixCommand : PSCmdlet, IDisposable
{
Expand Down Expand Up @@ -66,52 +66,61 @@ public sealed class GetHotFixCommand : PSCmdlet, IDisposable
private ManagementObjectSearcher _searchProcess;

private bool _inputContainsWildcard = false;
private readonly ConnectionOptions _connectionOptions = new ConnectionOptions { };

/// <summary>
/// Get the List of HotFixes installed on the Local Machine.
/// Sets connection options.
/// </summary>
protected override void BeginProcessing()
{
_connectionOptions.Authentication = AuthenticationLevel.Packet;
_connectionOptions.Impersonation = ImpersonationLevel.Impersonate;
_connectionOptions.Username = Credential?.UserName;
_connectionOptions.SecurePassword = Credential?.Password;
}

/// <summary>
/// Get the List of HotFixes installed on the Local Machine.
/// </summary>
protected override void ProcessRecord()
{
foreach (string computer in ComputerName)
{
bool foundRecord = false;
StringBuilder QueryString = new StringBuilder();
ConnectionOptions conOptions = new ConnectionOptions
{
Authentication = AuthenticationLevel.Packet,
Impersonation = ImpersonationLevel.Impersonate,
Username = Credential?.UserName,
SecurePassword = Credential?.Password
};

ManagementScope scope = new ManagementScope(ComputerWMIHelper.GetScopeString(computer, ComputerWMIHelper.WMI_Path_CIM), conOptions);
StringBuilder queryString = new StringBuilder();
ManagementScope scope = new ManagementScope(ComputerWMIHelper.GetScopeString(computer, ComputerWMIHelper.WMI_Path_CIM), _connectionOptions);
scope.Connect();
if (Id != null)
{
QueryString.Append("Select * from Win32_QuickFixEngineering where (");
queryString.Append("Select * from Win32_QuickFixEngineering where (");
for (int i = 0; i <= Id.Length - 1; i++)
{
QueryString.Append("HotFixID= '");
QueryString.Append(Id[i].ToString().Replace("'", "\\'"));
QueryString.Append("'");
queryString.Append("HotFixID= '");
queryString.Append(Id[i].Replace("'", "\\'"));
queryString.Append("'");
if (i < Id.Length - 1)
QueryString.Append(" Or ");
{
queryString.Append(" Or ");
}
}

QueryString.Append(")");
queryString.Append(")");
}
else
{
QueryString.Append("Select * from Win32_QuickFixEngineering");
queryString.Append("Select * from Win32_QuickFixEngineering");
foundRecord = true;
}

_searchProcess = new ManagementObjectSearcher(scope, new ObjectQuery(QueryString.ToString()));
_searchProcess = new ManagementObjectSearcher(scope, new ObjectQuery(queryString.ToString()));
foreach (ManagementObject obj in _searchProcess.Get())
{
if (Description != null)
{
if (!FilterMatch(obj))
{
continue;
}
}
else
{
Expand All @@ -126,13 +135,15 @@ protected override void BeginProcessing()
try
{
SecurityIdentifier secObj = new SecurityIdentifier(installed);
obj["InstalledBy"] = secObj.Translate(typeof(NTAccount)); ;
obj["InstalledBy"] = secObj.Translate(typeof(NTAccount));
}
catch (IdentityNotMappedException) // thrown by SecurityIdentifier.Translate
catch (IdentityNotMappedException)
{
// thrown by SecurityIdentifier.Translate
}
catch (SystemException) // thrown by SecurityIdentifier.constr
catch (SystemException)
{
// thrown by SecurityIdentifier.constr
}
}

Expand All @@ -142,8 +153,8 @@ protected override void BeginProcessing()

if (!foundRecord && !_inputContainsWildcard)
{
Exception Ex = new ArgumentException(StringUtil.Format(HotFixResources.NoEntriesFound, computer));
WriteError(new ErrorRecord(Ex, "GetHotFixNoEntriesFound", ErrorCategory.ObjectNotFound, null));
Exception ex = new ArgumentException(StringUtil.Format(HotFixResources.NoEntriesFound, computer));
WriteError(new ErrorRecord(ex, "GetHotFixNoEntriesFound", ErrorCategory.ObjectNotFound, null));
}

if (_searchProcess != null)
Expand Down
5 changes: 5 additions & 0 deletions test/powershell/Modules/Microsoft.PowerShell.Management/Get-HotFix.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,4 +58,9 @@ Describe "Get-HotFix Tests" -Tag CI {
$hotfixes = Get-HotFix -ComputerName localhost
$hotfixes.Count | Should -Be $qfe.Count
}

It "Get-Hotfix can accept ComputerName via pipeline" {
{ [PSCustomObject]@{ComputerName = 'UnavailableComputer'} | Get-HotFix } |Should -Throw -ErrorID 'Microsoft.PowerShell.Commands.GetHotFixCommand'
[PSCustomObject]@{ComputerName = 'localhost'} | Get-HotFix | Should -Not -BeNullOrEmpty
}
}
2 changes: 1 addition & 1 deletion test/powershell/engine/Help/assets/HelpURI/V2Cmdlets.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ Get-FormatData,https://go.microsoft.com/fwlink/?LinkID=144303
Get-Help,https://go.microsoft.com/fwlink/?LinkID=113316
Get-History,https://go.microsoft.com/fwlink/?LinkID=113317
Get-Host,https://go.microsoft.com/fwlink/?LinkID=113318
Get-Hotfix,https://go.microsoft.com/fwlink/?LinkID=135217
Get-Hotfix,https://go.microsoft.com/fwlink/?linkid=2109716
Get-Item,https://go.microsoft.com/fwlink/?LinkID=113319
Get-ItemProperty,https://go.microsoft.com/fwlink/?LinkID=113320
Get-Job,https://go.microsoft.com/fwlink/?LinkID=113328
Expand Down