Fedora 28 was released, Fedora 26 and 25 were EOL'ed.#6963
Fedora 28 was released, Fedora 26 and 25 were EOL'ed.#6963adelton wants to merge 1 commit intoPowerShell:masterfrom
Conversation
|
This looks good to me |
|
The I've updated the PR now -> 4f6ac478567dbb1b18842c6c0e9562829c68a295. |
bergmeister
left a comment
There was a problem hiding this comment.
Please pull in upstream chamges and revert the changes in the readme since the installation instructions recently got removed from this repo. You will need to add another pr then to the docs repo for that and only then you can update the readme.
|
Please see @bergmeister comments #6963 (review) |
|
Well, the current |
|
@adelton No, I already have PR #6981 open to fix the links in the Readme, hence why I suggest reverting the changes in the ReadMe and docs/installation/linux.md to get only the other changes in as part of this PR. |
|
The new PR in the docs repository has now been filed: MicrosoftDocs/PowerShell-Docs#2497 |
|
Rebased on master, removed the change in |
|
@adelton There still seems to be a merge conflict in |
|
Rebased on master -> 6ec3fc8. |
|
@bergmeister Have you comments? |
|
@iSazonov I don't know what MSFT's process on this is. Do they not need to build and test he image first produced from this changed Dockerfile before approving this PR? Other than that it looks OK to me if it works. |
|
@bergmeister We are going to be migrating the Dockerfiles to a separate repo with a CI system. I'll make the repo public as soon as I get the CI system working. @adelton I'm ok with this being merged without validation as this is not an image we have been publishing or you can wait and set it up in the new repo. If you set it up in the new repo with a CI test, it is more likely to get published. |
|
@adelton PowerShell/PowerShell-Docker is public now, with a CI system. I'm not quite ready to accept PRs as we need to split the images into stable and preview images due to various changes in preview.3. But the biggest changes will be to the paths where the files are located, I just won't merge your change until I've merged the change to split stable and preview. I'm happy to fix up your PR as long as you give me permissions. |
|
I've filed PowerShell/PowerShell-Docker#8 now. |
|
Not sure where you need the permission. |
|
I see that enabled (by default, apparently). |
|
Thanks for moving the PR. I think we can close this one now. |
This is basically a copy of Dockerfiles from PowerShell/PowerShell#6963.

PR Summary
Update the Linux installation instructions and container image definitions to match current Fedora versions (27, 28).
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests