Skip to content

Fedora 28 was released, Fedora 26 and 25 were EOL'ed.#6963

Closed
adelton wants to merge 1 commit intoPowerShell:masterfrom
adelton:fedora-28
Closed

Fedora 28 was released, Fedora 26 and 25 were EOL'ed.#6963
adelton wants to merge 1 commit intoPowerShell:masterfrom
adelton:fedora-28

Conversation

@adelton
Copy link
Copy Markdown
Contributor

@adelton adelton commented May 31, 2018

PR Summary

Update the Linux installation instructions and container image definitions to match current Fedora versions (27, 28).

PR Checklist

@kilasuit
Copy link
Copy Markdown
Collaborator

This looks good to me

@adelton
Copy link
Copy Markdown
Contributor Author

adelton commented May 31, 2018

The compat-openssl10 seems to be needed on latest Fedoras. Without it, the powershell rpm installs fine but it then fails in runtime, for example

PS /> get-packageprovider                                                       
No usable version of the libssl was found

I've updated the PR now -> 4f6ac478567dbb1b18842c6c0e9562829c68a295.

Copy link
Copy Markdown
Contributor

@bergmeister bergmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please pull in upstream chamges and revert the changes in the readme since the installation instructions recently got removed from this repo. You will need to add another pr then to the docs repo for that and only then you can update the readme.

@TravisEz13
Copy link
Copy Markdown
Member

Please see @bergmeister comments #6963 (review)

@adelton
Copy link
Copy Markdown
Contributor Author

adelton commented Jun 4, 2018

Well, the current README.md in master is broken -- there are still links to https://github.com/PowerShell/PowerShell/tree/master/docs/installation/linux.md on many lines of that table. Should I create separate PR to fix that or is someone working on fixing it already?

@bergmeister
Copy link
Copy Markdown
Contributor

bergmeister commented Jun 4, 2018

@adelton No, I already have PR #6981 open to fix the links in the Readme, hence why I suggest reverting the changes in the ReadMe and docs/installation/linux.md to get only the other changes in as part of this PR.
You then open another PR in the docs repo here to update the actual installation doc and once the doc PR is in, you can then add another PR here with the updated readme once the Doc change is live. Sorry, it is normally not that complicated/convoluted, you just had bad luck with the timing of other changes.
I think this makes sense from a process perspective though. Microsoft needs to first test that everything works well with Fedora 28 before announcing it.

@adelton
Copy link
Copy Markdown
Contributor Author

adelton commented Jun 4, 2018

The new PR in the docs repository has now been filed: MicrosoftDocs/PowerShell-Docs#2497

@adelton
Copy link
Copy Markdown
Contributor Author

adelton commented Jun 4, 2018

Rebased on master, removed the change in README.md -> 63a56ae92a3f8c1ad75eacc798e0e8d36c7dc646.

@bergmeister
Copy link
Copy Markdown
Contributor

bergmeister commented Jun 4, 2018

@adelton There still seems to be a merge conflict in docker/release/fedora26/Dockerfile
If it helps, the way how I upstream is:

git remote add upstream https://github.com/PowerShell/PowerShell.git # only needed once
git pull upstream master

@adelton
Copy link
Copy Markdown
Contributor Author

adelton commented Jun 5, 2018

Rebased on master -> 6ec3fc8.

Copy link
Copy Markdown

@anmenaga anmenaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iSazonov
Copy link
Copy Markdown
Collaborator

iSazonov commented Jun 7, 2018

@bergmeister Have you comments?

@bergmeister
Copy link
Copy Markdown
Contributor

@iSazonov I don't know what MSFT's process on this is. Do they not need to build and test he image first produced from this changed Dockerfile before approving this PR? Other than that it looks OK to me if it works.

@TravisEz13
Copy link
Copy Markdown
Member

@bergmeister We are going to be migrating the Dockerfiles to a separate repo with a CI system. I'll make the repo public as soon as I get the CI system working. @adelton I'm ok with this being merged without validation as this is not an image we have been publishing or you can wait and set it up in the new repo. If you set it up in the new repo with a CI test, it is more likely to get published.

@TravisEz13
Copy link
Copy Markdown
Member

@adelton PowerShell/PowerShell-Docker is public now, with a CI system. I'm not quite ready to accept PRs as we need to split the images into stable and preview images due to various changes in preview.3. But the biggest changes will be to the paths where the files are located, I just won't merge your change until I've merged the change to split stable and preview. I'm happy to fix up your PR as long as you give me permissions.
image

@adelton
Copy link
Copy Markdown
Contributor Author

adelton commented Jun 8, 2018

I've filed PowerShell/PowerShell-Docker#8 now.

@adelton
Copy link
Copy Markdown
Contributor Author

adelton commented Jun 8, 2018

Not sure where you need the permission.

@iSazonov
Copy link
Copy Markdown
Collaborator

iSazonov commented Jun 8, 2018

@adelton
Copy link
Copy Markdown
Contributor Author

adelton commented Jun 8, 2018

I see that enabled (by default, apparently).

@TravisEz13
Copy link
Copy Markdown
Member

Thanks for moving the PR. I think we can close this one now.

@TravisEz13 TravisEz13 closed this Jun 8, 2018
TravisEz13 pushed a commit to PowerShell/PowerShell-Docker that referenced this pull request Jun 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants