Skip to content

Add Fedora 28 and Fedora 27 image definitions.#8

Merged
TravisEz13 merged 7 commits intoPowerShell:masterfrom
adelton:fedora-28
Jun 9, 2018
Merged

Add Fedora 28 and Fedora 27 image definitions.#8
TravisEz13 merged 7 commits intoPowerShell:masterfrom
adelton:fedora-28

Conversation

@adelton
Copy link
Copy Markdown
Contributor

@adelton adelton commented Jun 8, 2018

This is basically a copy of Dockerfiles from PowerShell/PowerShell#6963.

@adelton
Copy link
Copy Markdown
Contributor Author

adelton commented Jun 8, 2018

I did not include other files found in release/centos7:

  • getLatestTag.ps1 talks about xenial in comment;
  • psVersions.json and tags.json seem to be the same across centos7 and ubuntu* directories ... so they should not be duplicated in the first place.

It it's critical that these files are in Fedora subdirectories as well, I can of course add copy there as well.

@TravisEz13
Copy link
Copy Markdown
Member

The other files are used to automate our builds. I'm going to add them... hopefully in the next hour.

@TravisEz13
Copy link
Copy Markdown
Member

I just rebased your branch. So you will have to force sync it.. if you want to make a change.

@TravisEz13
Copy link
Copy Markdown
Member

TravisEz13 commented Jun 9, 2018

Fedora 28 is not listed as supported. I'll move 28 to the community folder. https://github.com/dotnet/core/blob/master/release-notes/2.0/2.0-supported-os.md#linux

Update:
Sorry, it is supported for 2.1 https://github.com/dotnet/core/blob/master/release-notes/2.1/2.1-supported-os.md

@TravisEz13
Copy link
Copy Markdown
Member

I only put the Fedora 28 image in the preview folder. @adelton Could you add a readme.md either in this or after this PR explaining that Fedora 28 is only supported in DotNet 2.1 and there for only PowerShell 6.1?

@TravisEz13
Copy link
Copy Markdown
Member

TravisEz13 commented Jun 9, 2018

@adelton CI now passes. fedora is taking 10 minutes to build. Perhaps we should consider splitting up the builds some other way, but we shouldn't hold up your PR for this. I only made minimal changes to your docker files, all of which are contained within this commit: 3612745

We normally give 24 hours for review, but with the weekend starting. I'm going to merge. Feel free to still comment on my changes.

The tags.json is the tag format for the image.

The psVersions.json is the version of PowerShell we will build an image for.

getLatestTag.ps1 returns a structure telling us a tag to build from and how to represent that tag in the tag template. Here are the properties of the structure:

Name description
Tag What we should tag the image
Type Full or Short. Some images have two representations of the same tag. A full descriptive tag, and short. Just say which one the 'Tag' property is. For example for xenial, a short tag would be xenial and a long tag would be xenial-20180525.
FromTag the tag we should build the image from. We should try to use the most descriptive tag. For example for Ubuntu, I would use xenial-20180525

There is a helper here which can generate these for you most of the time.

@TravisEz13 TravisEz13 merged commit f1895b6 into PowerShell:master Jun 9, 2018
@TravisEz13
Copy link
Copy Markdown
Member

@adelton Thanks for your contribution.

@adelton
Copy link
Copy Markdown
Contributor Author

adelton commented Jun 11, 2018

Thank you.

@adelton adelton deleted the fedora-28 branch June 11, 2018 08:18
@TravisEz13
Copy link
Copy Markdown
Member

I filed #9 to document the files and fields I started documenting above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants