Add Fedora 28 and Fedora 27 image definitions.#8
Add Fedora 28 and Fedora 27 image definitions.#8TravisEz13 merged 7 commits intoPowerShell:masterfrom
Conversation
|
I did not include other files found in
It it's critical that these files are in Fedora subdirectories as well, I can of course add copy there as well. |
|
The other files are used to automate our builds. I'm going to add them... hopefully in the next hour. |
|
I just rebased your branch. So you will have to force sync it.. if you want to make a change. |
|
Fedora 28 is not listed as supported. I'll move 28 to the community folder. https://github.com/dotnet/core/blob/master/release-notes/2.0/2.0-supported-os.md#linux Update: |
|
I only put the Fedora 28 image in the preview folder. @adelton Could you add a readme.md either in this or after this PR explaining that Fedora 28 is only supported in DotNet 2.1 and there for only PowerShell 6.1? |
|
@adelton CI now passes. fedora is taking 10 minutes to build. Perhaps we should consider splitting up the builds some other way, but we shouldn't hold up your PR for this. I only made minimal changes to your docker files, all of which are contained within this commit: 3612745 We normally give 24 hours for review, but with the weekend starting. I'm going to merge. Feel free to still comment on my changes. The tags.json is the tag format for the image. The psVersions.json is the version of PowerShell we will build an image for. getLatestTag.ps1 returns a structure telling us a tag to build from and how to represent that tag in the tag template. Here are the properties of the structure:
There is a helper here which can generate these for you most of the time. |
|
@adelton Thanks for your contribution. |
|
Thank you. |
|
I filed #9 to document the files and fields I started documenting above. |
This is basically a copy of
Dockerfiles from PowerShell/PowerShell#6963.