FOUR-18315 | Include Tests For Accurate Filtering and Display of Templates#7369
Merged
sanjacornelius merged 4 commits intoepic/FOUR-18012from Sep 16, 2024
Merged
FOUR-18315 | Include Tests For Accurate Filtering and Display of Templates#7369sanjacornelius merged 4 commits intoepic/FOUR-18012from
sanjacornelius merged 4 commits intoepic/FOUR-18012from
Conversation
Add data-cy attribute to templates button for testing
Remove fetching of data from core
sanjacornelius
approved these changes
Sep 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task
Ticket: FOUR-18315
This PR introduces comprehensive Cypress tests for the Screen Templates Panel in
screen-builderand adds template-fetching functionality toscreen-builder.The tests check that:
This PR also refactors the handling of templates data, and the show/close functionality for the Screen Templates Panel.
How to Test
task/FOUR-18315inscreen-builderandprocessmaker.npx open cypressandnpm run devin yourscreen-builderterminal.ScreenTemplateSection.spec.jsin Cypress.ci:next
Screen Builder PR
Code Review Checklist