FOUR-18303 | Write Tests for Screen Templates Section#1697
Merged
sanjacornelius merged 6 commits intoepic/FOUR-18012from Sep 16, 2024
Merged
FOUR-18303 | Write Tests for Screen Templates Section#1697sanjacornelius merged 6 commits intoepic/FOUR-18012from
sanjacornelius merged 6 commits intoepic/FOUR-18012from
Conversation
…ot installed Also for use in screen-builder standalone
For cypress testing and screen-builder standalone
screen-builder
|
||||||||||||||||||||||||||||
| Project |
screen-builder
|
| Branch Review |
task/FOUR-18303
|
| Run status |
|
| Run duration | 07m 18s |
| Commit |
|
| Committer | Teisha McRae |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
|
0
|
|
|
0
|
|
|
19
|
|
|
0
|
|
|
301
|
| View all changes introduced in this branch ↗︎ | |
Contributor
sanjacornelius
left a comment
There was a problem hiding this comment.
Hey @mcraeteisha I also noticed some functionality issues,
- On subsequent clicks of the "Templates" button the templates panel does not appear.
- When a control is selected then the "Templates" button is selected the templates panel does not appear.
I believe these were working previously but I might be doing something wrong since I am just testing in standalone SB.
Contributor
|
Observations will or have been resolve in ProcessMaker/processmaker#7369 |
sanjacornelius
approved these changes
Sep 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Ticket: FOUR-18303
This PR introduces comprehensive Cypress tests for the Screen Templates Panel in screen-builder and enhances Screen Templates Panel visibility.
The tests check that:
This PR also Ensures the 'Templates' button is always visible, even without
package-versionsorprocessmakerintegration.How to Test
task/FOUR-18303inscreen-builderandprocessmaker.screen-builder.package-versionsinstalled, uninstall it and ensure that the 'Templates' button is still visible.npx open cypressandnpm run devin yourscreen-builderterminal.ScreenTemplateSection.jsin Cypress.ci:next
Code Review Checklist