Skip to content

FOUR-18303 | Write Tests for Screen Templates Section#1697

Merged
sanjacornelius merged 6 commits intoepic/FOUR-18012from
task/FOUR-18303
Sep 16, 2024
Merged

FOUR-18303 | Write Tests for Screen Templates Section#1697
sanjacornelius merged 6 commits intoepic/FOUR-18012from
task/FOUR-18303

Conversation

@mcraeteisha
Copy link
Copy Markdown
Contributor

@mcraeteisha mcraeteisha commented Sep 12, 2024

Issue

Ticket: FOUR-18303

This PR introduces comprehensive Cypress tests for the Screen Templates Panel in screen-builder and enhances Screen Templates Panel visibility.

The tests check that:

  • The Screen Templates Panel opens when the 'Templates' button is clicked
  • The Screen Templates Panel closes when the 'X' button in the Panel is clicked
  • The Screen Templates Panel is hidden when a control is clicked and an Inspector Panel should open

This PR also Ensures the 'Templates' button is always visible, even without package-versions or processmaker integration.

How to Test

  1. Go to branch task/FOUR-18303 in screen-builder and processmaker.
  2. Go to Designer → Screens. Create a Screen.
  3. The 'Templates' button should display in screen-builder.
    • If you have package-versions installed, uninstall it and ensure that the 'Templates' button is still visible.
  4. Run npx open cypress and npm run dev in your screen-builder terminal.
  5. Run tests for ScreenTemplateSection.js in Cypress.
    • All tests should pass.

ci:next

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines..
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

@cypress
Copy link
Copy Markdown

cypress bot commented Sep 12, 2024

screen-builder    Run #1329

Run Properties:  status check passed Passed #1329  •  git commit c8b1a14fd8: FOUR-18303 | Write Tests for Screen Templates Section
Project screen-builder
Branch Review task/FOUR-18303
Run status status check passed Passed #1329
Run duration 07m 18s
Commit git commit c8b1a14fd8: FOUR-18303 | Write Tests for Screen Templates Section
Committer Teisha McRae
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 19
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 301
View all changes introduced in this branch ↗︎

Copy link
Copy Markdown
Contributor

@sanjacornelius sanjacornelius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @mcraeteisha I also noticed some functionality issues,

  1. On subsequent clicks of the "Templates" button the templates panel does not appear.
  2. When a control is selected then the "Templates" button is selected the templates panel does not appear.

I believe these were working previously but I might be doing something wrong since I am just testing in standalone SB.

@sanjacornelius
Copy link
Copy Markdown
Contributor

Observations will or have been resolve in ProcessMaker/processmaker#7369

@sanjacornelius sanjacornelius merged commit b69ccd7 into epic/FOUR-18012 Sep 16, 2024
@sanjacornelius sanjacornelius deleted the task/FOUR-18303 branch September 16, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants