Use boolean types for boolean attributes in JSON#2302
Merged
blowekamp merged 4 commits intoSimpleITK:masterfrom Jun 2, 2025
Merged
Use boolean types for boolean attributes in JSON#2302blowekamp merged 4 commits intoSimpleITK:masterfrom
blowekamp merged 4 commits intoSimpleITK:masterfrom
Conversation
Change no_procedure to be set as a boolean not a number.
8482d70 to
ef36fb4
Compare
dave3d
approved these changes
Jun 2, 2025
zivy
approved these changes
Jun 2, 2025
Member
zivy
left a comment
There was a problem hiding this comment.
LGTM.
There were some places where "1" was converted to 1 and some to "true". Initially thought that was an error, but second look at the variables realized that these are correct conversions. In some cases the string represented the number and in some the boolean value.
Nicely done.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convert data representation from string or integers to boolean value types in JSON.