Skip to content

Use boolean types for boolean attributes in JSON #2302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
blowekamp merged 4 commits into from
Jun 2, 2025
Merged

Use boolean types for boolean attributes in JSON #2302

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ef36fb4
Fix JSON to use 1 as a number an not a string
blowekamp May 30, 2025
6d6772c
Convert dim_vec to a boolean value in json and templates
blowekamp May 30, 2025
19820f7
Convert point_vec and set_as_scalar to boolean values
blowekamp May 30, 2025
370cd65
Make not_get_method a boolean in json and templates
blowekamp May 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Code/BasicFilters/json/AdaptiveHistogramEqualizationImageFilter.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@
"name" : "Radius",
"type" : "unsigned int",
"default" : "std::vector<unsigned int>(3, 5)",
"dim_vec" : 1,
"set_as_scalar" : 1,
"dim_vec" : true,
"set_as_scalar" : true,
"itk_type" : "typename FilterType::RadiusType"
},
{
Expand Down
6 changes: 3 additions & 3 deletions Code/BasicFilters/json/AdditiveGaussianNoiseImageFilter.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
{
"tag" : "2d",
"description" : "2D - baseline as zero noise",
"no_procedure" : 1,
"no_procedure" : true,
"settings" : [
{
"parameter" : "Seed",
Expand All @@ -55,7 +55,7 @@
{
"tag" : "3d",
"description" : "3D - baseline as zero noise",
"no_procedure" : 1,
"no_procedure" : true,
"settings" : [
{
"parameter" : "Seed",
Expand All @@ -75,7 +75,7 @@
{
"tag" : "rgb",
"description" : "vector image - baseline as zero noise",
"no_procedure" : 1,
"no_procedure" : true,
"settings" : [
{
"parameter" : "Seed",
Expand Down
2 changes: 1 addition & 1 deletion Code/BasicFilters/json/BilateralImageFilter.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@
{
"tag" : "3d",
"description" : "small kernel in 3d",
"no_procedure" : 1,
"no_procedure" : true,
"settings" : [
{
"parameter" : "DomainSigma",
Expand Down
4 changes: 2 additions & 2 deletions Code/BasicFilters/json/BinShrinkImageFilter.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"name" : "ShrinkFactors",
"type" : "unsigned int",
"default" : "std::vector<unsigned int>(3, 1)",
"dim_vec" : 1,
"dim_vec" : true,
"doc" : "",
"itk_type" : "typename FilterType::ShrinkFactorsType",
"briefdescriptionSet" : "",
Expand All @@ -37,7 +37,7 @@
{
"parameter" : "ShrinkFactor",
"type" : "unsigned int",
"no_get_method" : 1,
"no_get_method" : true,
"value" : "4"
}
],
Expand Down
6 changes: 3 additions & 3 deletions Code/BasicFilters/json/BinaryClosingByReconstructionImageFilter.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@
"name" : "KernelRadius",
"type" : "unsigned int",
"default" : "std::vector<uint32_t>(3, 1)",
"dim_vec" : 1,
"set_as_scalar" : 1,
"dim_vec" : true,
"set_as_scalar" : true,
"doc" : "",
"custom_itk_cast" : "",
"briefdescriptionSet" : "",
Expand Down Expand Up @@ -63,7 +63,7 @@
"settings" : [
{
"parameter" : "KernelRadius",
"no_get_method" : 1,
"no_get_method" : true,
"value" : 10
},
{
Expand Down
8 changes: 4 additions & 4 deletions Code/BasicFilters/json/BinaryDilateImageFilter.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@
"name" : "KernelRadius",
"type" : "unsigned int",
"default" : "std::vector<uint32_t>(3, 1)",
"dim_vec" : 1,
"set_as_scalar" : 1,
"dim_vec" : true,
"set_as_scalar" : true,
"doc" : "",
"custom_itk_cast" : "",
"briefdescriptionSet" : "",
Expand Down Expand Up @@ -62,7 +62,7 @@
"settings" : [
{
"parameter" : "KernelRadius",
"no_get_method" : 1,
"no_get_method" : true,
"value" : 1
},
{
Expand Down Expand Up @@ -93,7 +93,7 @@
{
"parameter" : "KernelRadius",
"type" : "uint32_t",
"dim_vec" : 1,
"dim_vec" : true,
"value" : [
20,
1
Expand Down
6 changes: 3 additions & 3 deletions Code/BasicFilters/json/BinaryErodeImageFilter.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@
"name" : "KernelRadius",
"type" : "unsigned int",
"default" : "std::vector<uint32_t>(3, 1)",
"dim_vec" : 1,
"set_as_scalar" : 1,
"dim_vec" : true,
"set_as_scalar" : true,
"doc" : "",
"custom_itk_cast" : "",
"briefdescriptionSet" : "",
Expand Down Expand Up @@ -63,7 +63,7 @@
"settings" : [
{
"parameter" : "KernelRadius",
"no_get_method" : 1,
"no_get_method" : true,
"value" : 1
},
{
Expand Down
6 changes: 3 additions & 3 deletions Code/BasicFilters/json/BinaryMedianImageFilter.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@
"name" : "Radius",
"type" : "unsigned int",
"default" : "std::vector<unsigned int>(3, 1)",
"dim_vec" : 1,
"set_as_scalar" : 1,
"dim_vec" : true,
"set_as_scalar" : true,
"doc" : "",
"itk_type" : "typename FilterType::InputSizeType",
"briefdescriptionSet" : "",
Expand Down Expand Up @@ -47,7 +47,7 @@
"settings" : [
{
"parameter" : "Radius",
"no_get_method" : 1,
"no_get_method" : true,
"value" : 3
},
{
Expand Down
8 changes: 4 additions & 4 deletions Code/BasicFilters/json/BinaryMorphologicalClosingImageFilter.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@
"name" : "KernelRadius",
"type" : "unsigned int",
"default" : "std::vector<uint32_t>(3, 1)",
"dim_vec" : 1,
"set_as_scalar" : 1,
"dim_vec" : true,
"set_as_scalar" : true,
"doc" : "",
"custom_itk_cast" : "",
"briefdescriptionSet" : "",
Expand Down Expand Up @@ -63,7 +63,7 @@
"settings" : [
{
"parameter" : "KernelRadius",
"no_get_method" : 1,
"no_get_method" : true,
"value" : 1
},
{
Expand All @@ -89,7 +89,7 @@
"settings" : [
{
"parameter" : "KernelRadius",
"no_get_method" : 1,
"no_get_method" : true,
"value" : 5
},
{
Expand Down
6 changes: 3 additions & 3 deletions Code/BasicFilters/json/BinaryMorphologicalOpeningImageFilter.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@
"name" : "KernelRadius",
"type" : "unsigned int",
"default" : "std::vector<uint32_t>(3, 1)",
"dim_vec" : 1,
"set_as_scalar" : 1,
"dim_vec" : true,
"set_as_scalar" : true,
"doc" : "",
"custom_itk_cast" : "",
"briefdescriptionSet" : "",
Expand Down Expand Up @@ -63,7 +63,7 @@
"settings" : [
{
"parameter" : "KernelRadius",
"no_get_method" : 1,
"no_get_method" : true,
"value" : 1
},
{
Expand Down
6 changes: 3 additions & 3 deletions Code/BasicFilters/json/BinaryOpeningByReconstructionImageFilter.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@
"name" : "KernelRadius",
"type" : "unsigned int",
"default" : "std::vector<uint32_t>(3, 1)",
"dim_vec" : 1,
"set_as_scalar" : 1,
"dim_vec" : true,
"set_as_scalar" : true,
"doc" : "",
"custom_itk_cast" : "",
"briefdescriptionSet" : "",
Expand Down Expand Up @@ -73,7 +73,7 @@
"settings" : [
{
"parameter" : "KernelRadius",
"no_get_method" : 1,
"no_get_method" : true,
"value" : 5
},
{
Expand Down
2 changes: 1 addition & 1 deletion Code/BasicFilters/json/BinaryProjectionImageFilter.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
{
"parameter" : "ProjectionDimension",
"cxx_value" : "1u",
"value" : "1"
"value" : 1
},
{
"parameter" : "ForegroundValue",
Expand Down
6 changes: 3 additions & 3 deletions Code/BasicFilters/json/BlackTopHatImageFilter.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@
"name" : "KernelRadius",
"type" : "unsigned int",
"default" : "std::vector<uint32_t>(3, 1)",
"dim_vec" : 1,
"set_as_scalar" : 1,
"dim_vec" : true,
"set_as_scalar" : true,
"doc" : "",
"custom_itk_cast" : "",
"briefdescriptionSet" : "",
Expand Down Expand Up @@ -53,7 +53,7 @@
"settings" : [
{
"parameter" : "KernelRadius",
"no_get_method" : 1,
"no_get_method" : true,
"value" : 1
},
{
Expand Down
8 changes: 4 additions & 4 deletions Code/BasicFilters/json/BoxMeanImageFilter.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@
"name" : "Radius",
"type" : "unsigned int",
"default" : "std::vector<unsigned int>(3, 1)",
"dim_vec" : 1,
"set_as_scalar" : 1,
"dim_vec" : true,
"set_as_scalar" : true,
"doc" : "",
"itk_type" : "typename FilterType::RadiusType"
}
Expand All @@ -35,7 +35,7 @@
{
"parameter" : "Radius",
"type" : "unsigned int",
"dim_vec" : 1,
"dim_vec" : true,
"value" : [
2,
3
Expand All @@ -54,7 +54,7 @@
{
"parameter" : "Radius",
"type" : "unsigned int",
"dim_vec" : 1,
"dim_vec" : true,
"value" : [
3,
3,
Expand Down
8 changes: 4 additions & 4 deletions Code/BasicFilters/json/BoxSigmaImageFilter.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@
"name" : "Radius",
"type" : "unsigned int",
"default" : "std::vector<unsigned int>(3, 1)",
"dim_vec" : 1,
"set_as_scalar" : 1,
"dim_vec" : true,
"set_as_scalar" : true,
"doc" : "",
"itk_type" : "typename FilterType::RadiusType"
}
Expand All @@ -35,7 +35,7 @@
{
"parameter" : "Radius",
"type" : "unsigned int",
"dim_vec" : 1,
"dim_vec" : true,
"value" : [
2,
3
Expand All @@ -54,7 +54,7 @@
{
"parameter" : "Radius",
"type" : "unsigned int",
"dim_vec" : 1,
"dim_vec" : true,
"value" : [
3,
3,
Expand Down
10 changes: 5 additions & 5 deletions Code/BasicFilters/json/CannyEdgeDetectionImageFilter.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,8 @@
"type" : "double",
"default" : "std::vector<double>(3, 0.0)",
"doc" : "",
"dim_vec" : 1,
"set_as_scalar" : 1,
"dim_vec" : true,
"set_as_scalar" : true,
"itk_type" : "typename FilterType::ArrayType",
"briefdescriptionSet" : "",
"detaileddescriptionSet" : "Set/Get the variance of the Gaussian smoothing filter.",
Expand All @@ -44,8 +44,8 @@
"type" : "double",
"default" : "std::vector<double>(3, 0.01)",
"doc" : "",
"dim_vec" : 1,
"set_as_scalar" : 1,
"dim_vec" : true,
"set_as_scalar" : true,
"itk_type" : "typename FilterType::ArrayType",
"briefdescriptionSet" : "",
"detaileddescriptionSet" : "Set/Get the MaximumError parameter used by the Gaussian smoothing filter in this algorithm",
Expand Down Expand Up @@ -80,7 +80,7 @@
{
"parameter" : "Variance",
"type" : "double",
"dim_vec" : 1,
"dim_vec" : true,
"value" : [
1.0,
1.0,
Expand Down
2 changes: 1 addition & 1 deletion Code/BasicFilters/json/ChangeLabelImageFilter.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"name" : "ChangeMap",
"type" : "std::map<double,double>",
"default" : "std::map<double,double>()",
"no_print" : 1,
"no_print" : true,
"custom_itk_cast" : "typename FilterType::ChangeMapType cmap; for( std::map<double,double>::const_iterator i = m_ChangeMap.begin(); i != m_ChangeMap.end(); ++i ) { cmap[static_cast<typename FilterType::InputPixelType>(i->first)] = static_cast<typename FilterType::OutputPixelType>(i->second); } filter->SetChangeMap( cmap );",
"briefdescriptionSet" : "",
"detaileddescriptionSet" : "Set the entire change map"
Expand Down
2 changes: 1 addition & 1 deletion Code/BasicFilters/json/ChangeLabelLabelMapFilter.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"name" : "ChangeMap",
"type" : "std::map<double,double>",
"default" : "std::map<double,double>()",
"no_print" : 1,
"no_print" : true,
"custom_itk_cast" : "typename FilterType::ChangeMapType cmap; for( std::map<double,double>::const_iterator i = m_ChangeMap.begin(); i != m_ChangeMap.end(); ++i ) { cmap[static_cast<typename FilterType::PixelType>(i->first)] = static_cast<typename FilterType::PixelType>(i->second); } filter->SetChangeMap( cmap );",
"briefdescriptionSet" : "",
"detaileddescriptionSet" : "",
Expand Down
6 changes: 3 additions & 3 deletions Code/BasicFilters/json/CheckerBoardImageFilter.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@
"name" : "CheckerPattern",
"type" : "uint32_t",
"default" : "std::vector<uint32_t>(3, 4)",
"dim_vec" : 1,
"set_as_scalar" : 1,
"dim_vec" : true,
"set_as_scalar" : true,
"itk_type" : "typename FilterType::PatternArrayType",
"briefdescriptionSet" : "",
"detaileddescriptionSet" : "Set/Get the checker pattern array, i.e. the number of checker boxes per image dimension.",
Expand All @@ -38,7 +38,7 @@
{
"parameter" : "CheckerPattern",
"type" : "uint32_t",
"dim_vec" : 1,
"dim_vec" : true,
"value" : [
20,
4
Expand Down
6 changes: 3 additions & 3 deletions Code/BasicFilters/json/ClosingByReconstructionImageFilter.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@
"name" : "KernelRadius",
"type" : "unsigned int",
"default" : "std::vector<uint32_t>(3, 1)",
"dim_vec" : 1,
"set_as_scalar" : 1,
"dim_vec" : true,
"set_as_scalar" : true,
"doc" : "",
"custom_itk_cast" : "",
"briefdescriptionSet" : "",
Expand Down Expand Up @@ -63,7 +63,7 @@
"settings" : [
{
"parameter" : "KernelRadius",
"no_get_method" : 1,
"no_get_method" : true,
"value" : 1
},
{
Expand Down
Loading