Fix two issues affecting CMCDSample in the development environment#8
Merged
jeanfrancoislarente merged 2 commits intoSitecore:developfrom May 7, 2018
Merged
Fix two issues affecting CMCDSample in the development environment#8jeanfrancoislarente merged 2 commits intoSitecore:developfrom
jeanfrancoislarente merged 2 commits intoSitecore:developfrom
Conversation
jeanfrancoislarente
approved these changes
May 7, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default VS2017 docker-compose project needs some custom properties in order to handle custom solution configuration with a name other than the default ones, "Debug" and "Release". This was causing issues to run the CD and CM containers in the development environment and has been solved.
A small change has also been introduced to facilitate the attachment of VS to the running containers for debugging.