Fix uploaded logo URLs to respect Force HTTPS setting#605
Merged
Fyb3roptik merged 1 commit intoThreadfin:branch-1.2.35from Jul 1, 2025
Merged
Fix uploaded logo URLs to respect Force HTTPS setting#605Fyb3roptik merged 1 commit intoThreadfin:branch-1.2.35from
Fyb3roptik merged 1 commit intoThreadfin:branch-1.2.35from
Conversation
750fc39 to
9adf2a9
Compare
Contributor
|
This is still in a draft state. Is this ready? |
Contributor
Author
|
yes, this should be good to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #604
Uploaded channel logos weren't using HTTPS URLs even when Force HTTPS was enabled in settings.
I applied a fix to the
uploadLogofunction to check the Force HTTPS setting and generate the correct URL.Fixes the issue where external cached images used HTTPS correctly but uploaded logos still used HTTP.