Skip to content

Fix uploaded logo URLs to respect Force HTTPS setting #605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Fyb3roptik merged 1 commit into from
Jul 1, 2025
+7 −0
Merged

Fix uploaded logo URLs to respect Force HTTPS setting #605

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/images.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,14 @@ func uploadLogo(input, filename string) (logoURL string, err error) {
return
}

// Respect Force HTTPS setting when generating logo URL
if Settings.ForceHttps && Settings.HttpsThreadfinDomain != "" {
logoURL = fmt.Sprintf("https://%s:%d/data_images/%s", Settings.HttpsThreadfinDomain, Settings.HttpsPort, filename)
} else if Settings.HttpThreadfinDomain != "" {
logoURL = fmt.Sprintf("http://%s:%s/data_images/%s", Settings.HttpThreadfinDomain, Settings.Port, filename)
} else {
logoURL = fmt.Sprintf("%s://%s/data_images/%s", System.ServerProtocol.XML, System.Domain, filename)
}

return

Expand Down