Skip to content

feat(test): test Library for Dart users#3289

Closed
juliemr wants to merge 1 commit intoangular:masterfrom
juliemr:test-lib-package-3
Closed

feat(test): test Library for Dart users#3289
juliemr wants to merge 1 commit intoangular:masterfrom
juliemr:test-lib-package-3

Conversation

@juliemr
Copy link
Copy Markdown
Member

@juliemr juliemr commented Jul 25, 2015

This is a work in progress separate dart module for Dart consumers of Angular2 who wish to test on top of dart:test.

@juliemr
Copy link
Copy Markdown
Member Author

juliemr commented Jul 25, 2015

Open questions

  • Do we like this syntax?
  • Should we use reflection and transformers to simplify the syntax, so that ngTest('the thing', [MyService], (MyService myService) {}) could just be ngTest('the thing', (MyService myService){})?

@juliemr
Copy link
Copy Markdown
Member Author

juliemr commented Jul 25, 2015

cc @kevmoo @sanfordredlich

yjbanov
yjbanov reviewed Aug 5, 2015
View reviewed changes
modules_dart/angular2_test/lib/test_lib.dart Outdated
Copy link
Copy Markdown
Contributor

@yjbanov yjbanov Aug 5, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which part is not public? The privacy of _currentTest is enforced by the language. What's left TODO here?

Copy link
Copy Markdown
Member Author

@juliemr juliemr Aug 7, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the Dart team, the Invoker.current API should not be relied upon, but a different version that will be formally public is coming soon...

@yjbanov
Copy link
Copy Markdown
Contributor

yjbanov commented Aug 5, 2015

Looks great. Let's see what users think about the syntax. Shouldn't be too hard to change it later.

@naomiblack naomiblack added this to the alpha-36 milestone Aug 6, 2015
@naomiblack
Copy link
Copy Markdown
Contributor

naomiblack commented Aug 6, 2015

@yjbanov since Julie is OOO, can you complete this? Should it be assigned to @hankduan? It would be nice to get this in.

@yjbanov
Copy link
Copy Markdown
Contributor

yjbanov commented Aug 7, 2015

@naomiblack I wouldn't be able to get to it any time soon. Also, I'm not sure what else Julie had in mind for this PR.

@juliemr
Copy link
Copy Markdown
Member Author

juliemr commented Aug 7, 2015

Checking in quickly - as far as I know, the remaining todos are

  • Address comments from users. It would be nice to do ngTest((Service service) {}) instead of ngTest([Service], (Service service)) if we could use reflection here. I haven't heard any other comments.
    • Fix invoker "private" API as mentioned above.

@mhevery mhevery modified the milestones: alpha-36, alpha-37 Sep 1, 2015
@tbosch
Copy link
Copy Markdown
Contributor

tbosch commented Sep 28, 2015

@juliemr is this still current?

@tbosch tbosch assigned juliemr and unassigned yjbanov Sep 28, 2015
@juliemr
Copy link
Copy Markdown
Member Author

juliemr commented Sep 28, 2015

I need to review the needs of dart customers and the dart team about the private API, but yes, this should still be done and I think the PR should be left open.

(For clarity - yes, I am picking this up again)

@naomiblack naomiblack modified the milestones: alpha-37, alpha-39 Oct 4, 2015
@IgorMinar IgorMinar modified the milestone: alpha-39 Oct 5, 2015
@naomiblack naomiblack modified the milestone: beta-00 Nov 2, 2015
kegluneq
kegluneq reviewed Dec 1, 2015
View reviewed changes
gulpfile.js
Copy link
Copy Markdown

@kegluneq kegluneq Dec 1, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this create a new temp dir on every executed gulp command? Maybe it should be moved into a subtask of test.dart.angular2_testing/ci?

Copy link
Copy Markdown
Member Author

@juliemr juliemr Dec 1, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah it is pretty terrible. I split into two subtasks so that at least the sane one can be run by itself.

@kegluneq
Copy link
Copy Markdown

kegluneq commented Dec 1, 2015

A couple of comments on the gulpfile, but otherwise LGTM when LGTTravis.

@juliemr juliemr force-pushed the test-lib-package-3 branch from 08574b6 to 3e58bac Compare December 1, 2015 02:35
@juliemr juliemr mentioned this pull request Dec 2, 2015
Closed
yjbanov
yjbanov reviewed Dec 3, 2015
View reviewed changes
modules_dart/angular2_testing/README.md Outdated
Copy link
Copy Markdown
Contributor

@yjbanov yjbanov Dec 3, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/against/to test/

@yjbanov
Copy link
Copy Markdown
Contributor

yjbanov commented Dec 3, 2015

This looks soooo much better than what we have now! L! G! T! M!

@yjbanov yjbanov added action: merge The PR is ready for merge by the caretaker action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Dec 3, 2015
@juliemr
feat(test): add angular2_testing dart library
2bf867d 
angular2_testing is a user-facing dart test library built on top of
the package:test dart unittest framework and runner. For usage,
see modules_dart/angular2_testing/README.md.
@juliemr juliemr force-pushed the test-lib-package-3 branch from 3e58bac to 2bf867d Compare December 3, 2015 19:03
@juliemr juliemr removed the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Dec 3, 2015
@juliemr
Copy link
Copy Markdown
Member Author

juliemr commented Dec 3, 2015

Thanks for the review!

@juliemr juliemr closed this in 93a1ec2 Dec 3, 2015
@jelbourn
Copy link
Copy Markdown
Contributor

jelbourn commented Dec 3, 2015

Closed via 93a1ec2

@kevmoo
Copy link
Copy Markdown
Contributor

kevmoo commented Dec 3, 2015

🤘

@avoivo
Copy link
Copy Markdown

avoivo commented Dec 7, 2015

Hello,

Should 'angular2_testing' package be on https://pub.dartlang.org ?

I cannot find it there.

@juliemr
Copy link
Copy Markdown
Member Author

juliemr commented Dec 7, 2015

@avoivo I am working on how to distribute, release and package - it'll be up soon.

@avoivo
Copy link
Copy Markdown

avoivo commented Dec 7, 2015

@juliemr looking forward 👍

@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot bot commented Sep 7, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@yjbanov yjbanov

Labels

action: merge The PR is ready for merge by the caretaker cla: yes

Projects

None yet

Milestone

beta.0

Development

Successfully merging this pull request may close these issues.