Skip to content

chore(test): move to using dart:test for dart unit tests#3258

Closed
juliemr wants to merge 1 commit intoangular:masterfrom
juliemr:guinness2
Closed

chore(test): move to using dart:test for dart unit tests#3258
juliemr wants to merge 1 commit intoangular:masterfrom
juliemr:guinness2

Conversation

@juliemr
Copy link
Copy Markdown
Member

@juliemr juliemr commented Jul 24, 2015

This is a work in progress PR showing how Angular2 tests could be migrated to using the new dart:test unit test runner and library.

@kevmoo
Copy link
Copy Markdown
Contributor

kevmoo commented Jul 24, 2015

Darn – broken by benchpress – I'll help you debug

@kevmoo
Copy link
Copy Markdown
Contributor

kevmoo commented Jul 24, 2015

You need to upgrade modules/benpress to use guinness2 as well – then you're golden

@juliemr
Copy link
Copy Markdown
Member Author

juliemr commented Jul 24, 2015

Yup, haven't touched the auxiliary parts yet. There's also some tests in
transformers that need updating.

On Thu, Jul 23, 2015 at 6:11 PM, Kevin Moore [email protected]
wrote:

You need to upgrade modules/benpress to use guinness2 as well – then
you're golden


Reply to this email directly or view it on GitHub
#3258 (comment).

@juliemr
Copy link
Copy Markdown
Member Author

juliemr commented Jul 24, 2015

Updated with a little script that generates one big file to run all tests. This lets us use iit and ddescribe as expected.

@juliemr
Copy link
Copy Markdown
Member Author

juliemr commented Jul 25, 2015

Open issues

  • shadow dom css tests are broken. I debugged a bit and I'm not sure they're actually running at all - they fail when I run manually
  • Debugging is still a concern. See Support debugging browser tests dart-lang/test#45
  • The 'dart server' tests have not yet been upgraded.
  • Need to make sure that this is acceptably fast. In a quick test on my machine, running the whole suite takes 37 seconds on guinness2, as opposed to ~2 minutes on karma-dart. However, the actual time spent running test with karma-dart is much faster, only 9 seconds.

@tbosch
Copy link
Copy Markdown
Contributor

tbosch commented Jul 27, 2015

@juliemr I am in the progress of changing the shadow dom tests. Don't worry...

@naomiblack
Copy link
Copy Markdown
Contributor

@yjbanov can you complete this one since julie is OOO?

@naomiblack naomiblack added this to the alpha-36 milestone Aug 6, 2015
@mhevery mhevery modified the milestones: alpha-36, alpha-37 Sep 1, 2015
@tbosch
Copy link
Copy Markdown
Contributor

tbosch commented Sep 28, 2015

@juliemr are you still working on this?

@tbosch tbosch assigned juliemr and unassigned yjbanov Sep 28, 2015
@juliemr
Copy link
Copy Markdown
Member Author

juliemr commented Sep 28, 2015

@tbosch it's still on my todos but I'm not actively able to work on in probably for the next week or so.

@naomiblack naomiblack modified the milestones: alpha-37, alpha-39 Oct 4, 2015
@IgorMinar IgorMinar modified the milestone: alpha-39 Oct 5, 2015
@naomiblack naomiblack added this to the beta-00 milestone Nov 2, 2015
@naomiblack naomiblack added this to the beta-00 milestone Nov 2, 2015
@juliemr
Copy link
Copy Markdown
Member Author

juliemr commented Dec 2, 2015

I don't think this should be beta-0, since there are still blockers on debugging and tests taking too long. I'm moving to beta.1, please yell at me if you feel otherwise.

@juliemr juliemr modified the milestones: beta.1, beta.0 Dec 2, 2015
@kevmoo
Copy link
Copy Markdown
Contributor

kevmoo commented Dec 2, 2015

@juliemr I'd love to get this out ASAP. It's not changing anything that exists – just providing a new option.

pkg/test is THE way to easily run browser tests. If this works, we should get it out.

@juliemr
Copy link
Copy Markdown
Member Author

juliemr commented Dec 2, 2015

@kevmoo just making sure we're on the same page - this is a separate issue from providing a library on top of dart:test (#3289) - this issue is about migrating Angular2's own internal tests. So it does involve quite a bit of changing things that already exist.

@mhevery mhevery modified the milestones: beta.01, beta.02 Jan 25, 2016
@juliemr
Copy link
Copy Markdown
Member Author

juliemr commented Jan 31, 2016

Note to all: I am actively picking this up again (moving angular tests to the new dart tests runner).

@kevmoo
Copy link
Copy Markdown
Contributor

kevmoo commented Jan 31, 2016

Woo hoo! 🤘

@juliemr
Copy link
Copy Markdown
Member Author

juliemr commented Feb 16, 2016

This is so out of date I just made a new one - see instead #7111

@juliemr juliemr closed this Feb 16, 2016
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants