Skip to content

refactor(core): simplifying the ComponentFactory usage#68169

Merged
kirjs merged 1 commit intoangular:mainfrom
JeanMeche:component-factory-cleanup
Apr 13, 2026
Merged

refactor(core): simplifying the ComponentFactory usage#68169
kirjs merged 1 commit intoangular:mainfrom
JeanMeche:component-factory-cleanup

Conversation

@JeanMeche
Copy link
Copy Markdown
Member

The ComponentFactory has been removed from the public API in #68055. This commit continues the cleanup and also removes ModuleWithComponentFactories from the public API.

@angular-robot angular-robot bot added the area: core Issues related to the framework runtime label Apr 13, 2026
@ngbot ngbot bot added this to the Backlog milestone Apr 13, 2026
The `ComponentFactory` has been removed from the public API in angular#68055.
This commit continues the cleanup and also removes `ModuleWithComponentFactories` from the public API.
@JeanMeche JeanMeche force-pushed the component-factory-cleanup branch from cd6f7f6 to 2a7fd45 Compare April 13, 2026 14:44
@pullapprove pullapprove bot requested a review from AndrewKushnir April 13, 2026 18:58
Copy link
Copy Markdown
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-for: public-api

@AndrewKushnir AndrewKushnir requested review from atscott and removed request for devversion April 13, 2026 18:59
@JeanMeche JeanMeche added action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release labels Apr 13, 2026
@JeanMeche JeanMeche removed the request for review from atscott April 13, 2026 19:03
@ngbot
Copy link
Copy Markdown

ngbot bot commented Apr 13, 2026

I see that you just added the action: merge label, but the following checks are still failing:
    failure status "google-internal-tests" is failing
    pending 1 pending code review

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken main, please try rebasing to main and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@JeanMeche JeanMeche added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Apr 13, 2026
@JeanMeche
Copy link
Copy Markdown
Member Author

Caretaker note: Presubmit failure is a flake. This is good to go

@kirjs kirjs merged commit f9b74e9 into angular:main Apr 13, 2026
23 of 25 checks passed
@kirjs
Copy link
Copy Markdown
Contributor

kirjs commented Apr 13, 2026

This PR was merged into the repository. The changes were merged into the following branches:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: major This PR is targeted for the next major release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants