Skip to content

refactor(core): remove ComponentFactoryResolver & ComponentFactory from the api surface#68055

Merged
atscott merged 1 commit intoangular:mainfrom
JeanMeche:core/remove-factory-resolver
Apr 7, 2026
Merged

refactor(core): remove ComponentFactoryResolver & ComponentFactory from the api surface#68055
atscott merged 1 commit intoangular:mainfrom
JeanMeche:core/remove-factory-resolver

Conversation

@JeanMeche
Copy link
Copy Markdown
Member

@JeanMeche JeanMeche commented Apr 6, 2026

Those APIs date back to pre-ivy times and are long deprecated.

BREAKING CHANGE: ComponentFactoryResolver and ComponentFactory are no longer available. Pass the component class directly to APIs that previously required a factory, such as ViewContainerRef.createComponent or use the standalone createComponentFunction.

@JeanMeche JeanMeche requested a review from atscott April 6, 2026 21:26
@pullapprove pullapprove bot requested a review from crisbeto April 6, 2026 21:26
@angular-robot angular-robot bot added detected: breaking change PR contains a commit with a breaking change area: core Issues related to the framework runtime labels Apr 6, 2026
@JeanMeche JeanMeche added action: global presubmit The PR is in need of a google3 global presubmit and removed area: core Issues related to the framework runtime detected: breaking change PR contains a commit with a breaking change labels Apr 6, 2026
@ngbot ngbot bot modified the milestone: Backlog Apr 6, 2026
@JeanMeche JeanMeche changed the title refactor(core): remove ComponentFactoryResolver & ComponentFactory fr… refactor(core): remove ComponentFactoryResolver & ComponentFactory from the api surface Apr 6, 2026
@pullapprove pullapprove bot requested a review from atscott April 6, 2026 21:33
Copy link
Copy Markdown
Contributor

@atscott atscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: public-api

…om the api surface""

Those APIs date back to pre-ivy times and are long deprecated.

BREAKING CHANGE: `ComponentFactoryResolver` and `ComponentFactory` are no longer available. Pass the component class directly to APIs that previously required a factory, such as `ViewContainerRef.createComponent` or use the standalone `createComponent` function.
@JeanMeche JeanMeche force-pushed the core/remove-factory-resolver branch from 942101b to 595d5d7 Compare April 7, 2026 06:20
@angular-robot angular-robot bot added detected: breaking change PR contains a commit with a breaking change area: core Issues related to the framework runtime labels Apr 7, 2026
@ngbot ngbot bot added this to the Backlog milestone Apr 7, 2026
@JeanMeche
Copy link
Copy Markdown
Member Author

Green TGP

@JeanMeche JeanMeche added action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release and removed action: global presubmit The PR is in need of a google3 global presubmit labels Apr 7, 2026
@ngbot
Copy link
Copy Markdown

ngbot bot commented Apr 7, 2026

I see that you just added the action: merge label, but the following checks are still failing:
    failure status "google-internal-tests" is failing
    pending missing required labels: target: *
    pending 1 pending code review

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken main, please try rebasing to main and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@JeanMeche JeanMeche removed the request for review from crisbeto April 7, 2026 10:12
@atscott atscott merged commit b1f5181 into angular:main Apr 7, 2026
23 of 25 checks passed
@atscott
Copy link
Copy Markdown
Contributor

atscott commented Apr 7, 2026

This PR was merged into the repository. The changes were merged into the following branches:

JeanMeche added a commit to JeanMeche/angular that referenced this pull request Apr 12, 2026
This API was deprecated for a longtime, and was remove by angular#68055 from the public API.

We do have alternatives to this old API, so we can entirely remove it to spare some bytes
JeanMeche added a commit to JeanMeche/angular that referenced this pull request Apr 12, 2026
This API was deprecated for a longtime, and was remove by angular#68055 from the public API.

We do have alternatives to this old API, so we can entirely remove it to spare some bytes
JeanMeche added a commit to JeanMeche/angular that referenced this pull request Apr 12, 2026
This API was deprecated for a longtime, and was remove by angular#68055 from the public API.

We do have alternatives to this old API, so we can entirely remove it to spare some bytes
JeanMeche added a commit to JeanMeche/angular that referenced this pull request Apr 12, 2026
This API was deprecated for a longtime, and was remove by angular#68055 from the public API.

We do have alternatives to this old API, so we can entirely remove it to spare some bytes
JeanMeche added a commit to JeanMeche/angular that referenced this pull request Apr 12, 2026
This API was deprecated for a longtime, and was remove by angular#68055 from the public API.

We do have alternatives to this old API, so we can entirely remove it to spare some bytes
JeanMeche added a commit to JeanMeche/angular that referenced this pull request Apr 12, 2026
This API was deprecated for a longtime, and was remove by angular#68055 from the public API.

We do have alternatives to this old API, so we can entirely remove it to spare some bytes
JeanMeche added a commit to JeanMeche/angular that referenced this pull request Apr 12, 2026
This API was deprecated for a longtime, and was remove by angular#68055 from the public API.

We do have alternatives to this old API, so we can entirely remove it to spare some bytes
JeanMeche added a commit to JeanMeche/angular that referenced this pull request Apr 12, 2026
This API was deprecated for a longtime, and was remove by angular#68055 from the public API.

We do have alternatives to this old API, so we can entirely remove it to spare some bytes
JeanMeche added a commit to JeanMeche/angular that referenced this pull request Apr 12, 2026
This API was deprecated for a longtime, and was remove by angular#68055 from the public API.

We do have alternatives to this old API, so we can entirely remove it to spare some bytes
kirjs pushed a commit that referenced this pull request Apr 13, 2026
This API was deprecated for a longtime, and was remove by #68055 from the public API.

We do have alternatives to this old API, so we can entirely remove it to spare some bytes
JeanMeche added a commit to JeanMeche/angular that referenced this pull request Apr 13, 2026
The `ComponentFactory` has been removed from the public API in angular#68055.
This commit continues the cleanup and also removes `ModuleWithComponentFactories` from the public API.
JeanMeche added a commit to JeanMeche/angular that referenced this pull request Apr 13, 2026
The `ComponentFactory` has been removed from the public API in angular#68055.
This commit continues the cleanup and also removes `ModuleWithComponentFactories` from the public API.
kirjs pushed a commit that referenced this pull request Apr 13, 2026
The `ComponentFactory` has been removed from the public API in #68055.
This commit continues the cleanup and also removes `ModuleWithComponentFactories` from the public API.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime detected: breaking change PR contains a commit with a breaking change target: major This PR is targeted for the next major release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants