feat(firestore): options to include document ID on valueChanges()#2113
Merged
jamesdaniels merged 7 commits intoangular:masterfrom Nov 11, 2020
Merged
Conversation
jamesdaniels
approved these changes
Jun 23, 2019
Member
jamesdaniels
left a comment
There was a problem hiding this comment.
LGTM, thanks! Will merge once ready to cut 5.3
|
This is very important feature, thank you |
|
I think this does not work if you call it on a collection instead of a document |
|
This is what I had to do to make it work on a collection. Perhaps there is better way, but this is my first week with rxjs: |
Contributor
Are there any updates to this PR? It's been a while since release 5.3. |
Member
|
Whoops, meant to get this into 5.3 but working on 6 ate up all my time. Will get this into 6.1. |
|
Can this be added to 6.0.4? |
Member
|
New API so had to wait for a minor, will aim to get this in today for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
valueChanges()when reading a single document #2109yarn install,yarn testrun successfully? YesDescription
Continuation of #1976 - added
idFieldoption fordocument.valuChanges()to include the document ID on the emitted data payload. Updated documentation for this one and added some missing changes from the previous PR.Code sample