feat: map doc ID to the provided idField in a collection group query#2580
Merged
jamesdaniels merged 3 commits intoangular:masterfrom Nov 11, 2020
Merged
Conversation
Contributor
|
It was done already, but still not merged by @jamesdaniels :( |
Contributor
Author
|
@mjastrzebowski Ohh, I did not search back that far, sorry. In that case that PR should be merged and this can be closed/deleted. However I don't want to close this PR now as it's pretty new and maybe it catches the eye of one of the maintainers sooner than yours, is that OK with you? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
yarn install,yarn testrun successfully? yesDescription
This PR adds the missing implementation of mapping a document's ID to the field provided in
collectionGroupQuery.valueChanges({ idField: 'docId' }).It also updates the code example in the docs to use valid JS/TS.
Code sample