Skip to content

fix: exception while running command ng deploy (#2088)#2221

Closed
ngdevelop-tech wants to merge 4 commits intoangular:masterfrom
ngdevelop-tech:ng-deploy-fix
Closed

fix: exception while running command ng deploy (#2088)#2221
ngdevelop-tech wants to merge 4 commits intoangular:masterfrom
ngdevelop-tech:ng-deploy-fix

Conversation

@ngdevelop-tech
Copy link
Copy Markdown

@ngdevelop-tech ngdevelop-tech commented Oct 13, 2019

Checklist

  • Issue number for this PR: Exception while running command: ng run x:deploy #2088(required)
  • Docs included?: (yes/no; required for all API/functional changes)
  • Test units included?: (yes/no; required)
  • In a clean directory, yarn install, yarn test run successfully? (yes/no; required)

Description

When we execute ng deploy command, workspace.root gives the wrong path in the Windows environment, that's why it doesn't work in the Windows environment.
Using only project root In getFirebaseProjectName and deploy, will successfully allow ng deploy while executing it at project root in windows and linux environment.
fixes #2088

@ngdevelop-tech
fix: exception while running command ng deploy (angular#2088)
d352cec 
When we execute `ng deploy` command, `workspace.root` gives wrong path in Windows environment, thats why it doesn't work in Windows environment.
Using only `project root` In `getFirebaseProjectName` and `deploy`, will  successfully allow `ng deploy` while executing it at project root in windows and linux environment.
fixes angular#2088
@ngdevelop-tech
Copy link
Copy Markdown
Author

ngdevelop-tech commented Oct 25, 2019

@NothingEverHappens, Thanks for the approval.
Please help me, What should I do further to resolve failed build?
Do I need to merge the master branch again? ,
In Logs it is showing one log for version mismatch.

@NothingEverHappens
Copy link
Copy Markdown
Contributor

NothingEverHappens commented Oct 25, 2019

@ngdevelop-tech
My understanding is that this is a build issue, and not PR issue, but I didn't look very deep,
I'm going to take a closer look next week.

Meanwhile you can try running ./node_modules/.bin/karma start --single-run --browsers ChromeHeadlessTravis --reporters mocha && yarn test:node && node tools/run-typings-test.js && bash ./test/ng-build/build.sh" on your machine to verify that it works locally

@NothingEverHappens NothingEverHappens mentioned this pull request Oct 26, 2019
Merged
NothingEverHappens
NothingEverHappens suggested changes Oct 27, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@NothingEverHappens NothingEverHappens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After testing it locally yesterday I'm not convinced this is the best solution.

I think the culprit is the normalize function which we should use in a platform aware way.

@ngdevelop-tech
Copy link
Copy Markdown
Author

ngdevelop-tech commented Oct 29, 2019

After testing it locally yesterday I'm not convinced this is the best solution.

I think the culprit is the normalize function which we should use in a platform aware way.

@NothingEverHappens Sorry for the delayed reply, I will look into solving this with a better approach.

@Splaktar
Copy link
Copy Markdown
Contributor

Splaktar commented Jan 26, 2020

Is this PR no longer needed now that PR #2279 has been merged to fix #2088?

@ngdevelop-tech
Copy link
Copy Markdown
Author

ngdevelop-tech commented Jan 28, 2020

@Splaktar because PR #2279 has been merged and closes the #2088, closing this PR.

@ngdevelop-tech ngdevelop-tech deleted the ng-deploy-fix branch April 21, 2020 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@NothingEverHappens NothingEverHappens NothingEverHappens requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Exception while running command: ng run x:deploy

4 participants

@ngdevelop-tech @NothingEverHappens @Splaktar @googlebot