fix(ci): Use node 10 to fix the build#2230
Merged
jamesdaniels merged 1 commit intoangular:masterfrom Oct 27, 2019
Merged
Conversation
peterennis
added a commit
to peterennis/angularfire2
that referenced
this pull request
Oct 28, 2019
fix(ci): Use node 10 to fix the build (angular#2230)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently node version for travis is LTS, which switched from 10 to 12 recently, hence all builds are failing because of node-gyp.
My understanding is that updating to firebase 7 would eventually allow us to switch back to LTS, but short term this should fix the build.
cc #2221