[ZEPPELIN-6220] Remove unused constructor in DownloadRequest.class#4970
Merged
Reamer merged 1 commit intoapache:masterfrom Jul 16, 2025
Merged
[ZEPPELIN-6220] Remove unused constructor in DownloadRequest.class#4970Reamer merged 1 commit intoapache:masterfrom
Reamer merged 1 commit intoapache:masterfrom
Conversation
ParkGyeongTae
approved these changes
Jul 15, 2025
Member
ParkGyeongTae
left a comment
There was a problem hiding this comment.
Great cleanup on DownloadRequest. Removing those unused constructors keeps the test utilities lean and easier to maintain.
Could you also fill out the “Questions” section of the PR template? Thanks!
Member
|
Could you update the Jira issue link in the PR description? |
Contributor
Author
I updated the link. Thanks for the check! |
Reamer
approved these changes
Jul 16, 2025
Contributor
Reamer
left a comment
There was a problem hiding this comment.
LGTM
The class is even written entirely by me. I think it's good that you are cleaning this up. The MalformedURLException should be caught in the actual test.
asf-gitbox-commits
pushed a commit
that referenced
this pull request
Jul 16, 2025
### What is this PR for? This PR removes unused overloaded constructors in the DownloadRequest class located at: zeppelin/zeppelin-test/src/main/java/org/apache/zeppelin/test/DownloadRequest.java. Specifically, the constructor: ``` public DownloadRequest(URL url, int retries) ``` is not used anywhere within the Zeppelin codebase or its test suite. Removing these unused constructors simplifies the class and reduces maintenance complexity, without affecting any functional behavior. As this constructor was removed, other constructors that were only used by it have also been removed accordingly. ### What type of PR is it? Refactoring ### Todos * [x] - Verify internal and external usage * [x] - Remove unused constructors ### What is the Jira issue? * Open an issue on Jira. [ZEPPELIN-6220](https://issues.apache.org/jira/browse/ZEPPELIN-6220) ### How should this be tested? * Strongly recommended: add automated unit tests for any new or changed behavior * Outline any manual steps to test the PR here. ### Screenshots (if appropriate) ### Questions: * Does the license files need to update? - no * Is there breaking changes for older versions? - no * Does this needs documentation? - no Closes #4970 from eunhwa99/ZEPPELIN-6220. Signed-off-by: Philipp Dallig <[email protected]> (cherry picked from commit 573fc4e) Signed-off-by: Philipp Dallig <[email protected]>
Contributor
|
Merged into master and branch-0.12 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
This PR removes unused overloaded constructors in the DownloadRequest class located at:
zeppelin/zeppelin-test/src/main/java/org/apache/zeppelin/test/DownloadRequest.java.
Specifically, the constructor:
is not used anywhere within the Zeppelin codebase or its test suite. Removing these unused constructors simplifies the class and reduces maintenance complexity, without affecting any functional behavior.
As this constructor was removed, other constructors that were only used by it have also been removed accordingly.
What type of PR is it?
Refactoring
Todos
What is the Jira issue?
How should this be tested?
Screenshots (if appropriate)
Questions: