Skip to content

[ZEPPELIN-6220] Remove unused constructor in DownloadRequest.class #4970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Reamer merged 1 commit into from
Jul 16, 2025
Merged

[ZEPPELIN-6220] Remove unused constructor in DownloadRequest.class #4970

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 2 additions & 26 deletions zeppelin-test/src/main/java/org/apache/zeppelin/test/DownloadRequest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,42 +17,17 @@

package org.apache.zeppelin.test;

import java.net.MalformedURLException;
import java.net.URL;
import java.util.Optional;

public class DownloadRequest {

private final URL url;
private final Optional<URL> alternativeUrl;
private final int retries;

public static final int DEFAULT_RETRIES = 3;

public DownloadRequest(String url, int retries) throws MalformedURLException {
this(url, null, retries);
}

public DownloadRequest(String url, String alternativeUrl) throws MalformedURLException {
this(url, alternativeUrl, DEFAULT_RETRIES);
}

public DownloadRequest(String url, String alternativeUrl, int retries)
throws MalformedURLException {
if (alternativeUrl != null) {
this.url = new URL(url);
this.alternativeUrl = Optional.of(new URL(alternativeUrl));
this.retries = retries;
} else {
this.url = new URL(url);
this.alternativeUrl = Optional.empty();
this.retries = retries;
}
}

public DownloadRequest(URL url, int retries) {
this(url, null, retries);
}

public DownloadRequest(URL url, URL alternativeUrl) {
this(url, alternativeUrl, DEFAULT_RETRIES);
}
Expand All @@ -75,3 +50,4 @@ public int getRetries() {
return retries;
}
}

Loading