Added tags to serialize all functional models. #10028
Conversation
|
Hello @shannnnnyyy 👋! It looks like you've made some changes in your pull request, so I've checked the code again for style.
Comment last updated at 2020-04-29 05:41:03 UTC |
b9779ed to
e885b08
Compare
|
uh oh, i made some sort of git mistake and it reverted the files back to a way old commit. let me see if i can fix this... |
26d836d to
b525b0a
Compare
|
This looks great! |
|
This will also need a rebase to pick up fixed for the unrelated CI failures. |
ca1f156 to
f581eba
Compare
e5e1072 to
f3b900b
Compare
| astmodels.SphericalRotationSequence([1.2, 2.3, 3.4, .3], 'xyzy'), | ||
| custom_and_analytical_inverse(), | ||
| ] | ||
| astmodels.AiryDisk2D(10., 0.5, 1.5), |
There was a problem hiding this comment.
People can specify parameter values as keyword arguments, right? It might be a good idea to also construct them that way, so we can protect that aspect of the public interface.
There was a problem hiding this comment.
Yeah - the existing tests didn't do it this way so I just stuck with supplying the arguments like that, but I can change them all to use keyword arguments.
|
This also needs a rebase to pick up the latest version of asdf. |
bb14e26 to
22e16c7
Compare
Added functional_models.py in io/misc/asdf/tags/transform with new tags for each of the functional models (with the exception of a few that already existed in polynomial and basic), as well as tests for each.
Tests pass for me locally, but will not here unless the new schemas in asdf-standard are pointed to.
closes #9959 with redundant changes.