Merged
Conversation
Codecov Report❌ Patch coverage is ❌ Your patch status has failed because the patch coverage (98.25%) is below the target coverage (100.00%). You can increase the patch coverage or adjust the target coverage.
Flags with carried forward coverage won't be shown. Click here to find out more.
📢 Thoughts on this report? Let us know! |
PallasAthenaie
pushed a commit
to athena-framework/contracts
that referenced
this pull request
Aug 2, 2025
PallasAthenaie
pushed a commit
to athena-framework/framework
that referenced
this pull request
Aug 2, 2025
PallasAthenaie
pushed a commit
to athena-framework/validator
that referenced
this pull request
Aug 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Currently files uploaded within a
multipart/form-datarequest have to be manually handled via HTTP::FormData.parse from the stdlib. This PR introduces a native way to easily handle file uploads much like you can handle serializing JSON request bodies.Additionally, it also provides a new
ATH::Fileconcept that can be used to represent a file on the filesystem without having to actually open it viaFile.open.Resolves #442
Changelog
ATH::Request#filesas an array ofATH::UploadedFileATHA::MapUploadedFileprovides a way similar toATHA::MapRequestBodyto access them more easilyATH::UploadedFiletoAVD::Constraints::FileandAVD::Constraints::ImageBefore merging, remember to add the
athena-framework/athenaprefix to the PR number in the PR title