Skip to content

ATH::Response improvements#563

Merged
Blacksmoke16 merged 3 commits intomasterfrom
response-improvments
Aug 2, 2025
Merged

ATH::Response improvements#563
Blacksmoke16 merged 3 commits intomasterfrom
response-improvments

Conversation

@Blacksmoke16
Copy link
Copy Markdown
Member

@Blacksmoke16 Blacksmoke16 commented Aug 2, 2025 •
edited
Loading

Context

Makes some improvements to ATH::Response and related subclasses now that we have ATH::AbstractFile added via #559.

Changelog

  • Breaking: Leverage ATH::AbstractFile within ATH::BinaryFileResponse
    • Constructor argument and getter file_path have been renamed to file and now returns a ATH::AbstractFile instance versus String
  • Setter methods on ATH::Response and subclasses now return self to better support method chaning

Before merging, remember to add the athena-framework/athena prefix to the PR number in the PR title

@Blacksmoke16
Leverage ATH::AbstractFile within ATH::BinaryFileResponse
5214bd0 
Make `ATH::Response` related types have fluent setter interface
@Blacksmoke16 Blacksmoke16 added component:framework kind:enhancement New functionality to an existing feature breaking labels Aug 2, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 2, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

Flag Coverage Δ
compiled 31.08% <2.43%> (-0.02%) ⬇️
unit 96.98% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
clock 100.00% <ø> (ø)
console 97.20% <ø> (ø)
dependency_injection 93.16% <ø> (ø)
dotenv 98.38% <ø> (ø)
event_dispatcher 95.90% <ø> (ø)
framework 98.11% <100.00%> (+<0.01%) ⬆️
image_size 96.63% <ø> (ø)
mercure 94.94% <ø> (ø)
mime 99.37% <ø> (ø)
negotiation 97.93% <ø> (ø)
routing 98.38% <ø> (ø)
serializer 95.83% <ø> (ø)
spec 93.80% <ø> (ø)
validator 95.90% <ø> (ø)

📢 Thoughts on this report? Let us know!

@Blacksmoke16 Blacksmoke16 changed the title ATH::Response improvements ATH::Response improvements Aug 2, 2025
@Blacksmoke16 Blacksmoke16 merged commit d2ccf2a into master Aug 2, 2025
13 of 14 checks passed
@Blacksmoke16 Blacksmoke16 deleted the response-improvments branch August 2, 2025 17:53
PallasAthenaie pushed a commit to athena-framework/contracts that referenced this pull request Aug 2, 2025
@Blacksmoke16
ATH::Response improvements (athena-framework/athena#563)
3d29fe5
PallasAthenaie pushed a commit to athena-framework/framework that referenced this pull request Aug 2, 2025
@Blacksmoke16
ATH::Response improvements (athena-framework/athena#563)
e5bc019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

breaking component:framework kind:enhancement New functionality to an existing feature

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Blacksmoke16